(feat) integrate smartctl exporter#5164
Conversation
|
@parsa97 Thanks a lot for this! |
clayton-cornell
left a comment
clayton-cornell
left a comment
There was a problem hiding this comment.
Several doc suggestions. I would like to do a second pass through the docs after the current suggestions are reviewed/implemented to see if I've missed anything.
clayton-cornell
added
the
type/docs
| @@ -0,0 +1,903 @@ | |||
| package smartctl_exporter | |||
There was a problem hiding this comment.
Is this the prometheus-community collector, just vendored into Alloy? If no, why are we not using the community exporter's collector?
There was a problem hiding this comment.
It's not possible to import community package as a dependency.
There was a problem hiding this comment.
Hi, thank you for the PR! I'm a bit concerned with the maintenance burden when adding code like this. I have a few questions:
- Does bundling the exporter with Alloy make much difference given that the user still has to install smartmontools? If they already have to install smartmontools, why not just also install the Prometheus exporter?
- Would it be possible to make the community package importable? I'd consider this a pre-requisite for this PR.
- Is there a reason why the upstream exporter doesn't use a native Go module like the one suggested here? Would they be interested in switching to it?
|
@clayton-cornell I moved smartctl from static to components. PTAL. |
clayton-cornell
left a comment
clayton-cornell
left a comment
There was a problem hiding this comment.
Most changes are for consistency and active voice.
| tags: | ||
| - text: Community | ||
| tooltip: This component is developed, maintained, and supported by the Alloy user community. | ||
| title: prometheus.exporter.smartctl | ||
| --- | ||
|
|
||
| # `prometheus.exporter.smartctl` | ||
|
|
||
| {{< docs/shared lookup="stability/community.md" source="alloy" version="<ALLOY_VERSION>" >}} |
There was a problem hiding this comment.
I double checked and there is no Community: true that I can see in smartctl.go so... this isn't a community supported component and the community parts can be removed here.... or if it IS a community supported component, then we are missing the community part in the component.Register`?
cc: @grafana/grafana-alloy-maintainers
5 participants
PR Description
This PR adds a new prometheus.exporter.smartctl component to Grafana Alloy for collecting hardware metrics from S.M.A.R.T enabled devices.
Which issue(s) this PR fixes
fixes: #230
fixes: #3799
Notes to the Reviewer
PR Checklist