Handle classifiers in FilePathToModuleCoordinates (fixed)#251
Merged
Conversation
jjohannes
force-pushed
the
improve-classifier-handling-2
branch
from
4cc91a3 to
85af170
Compare
✅ All tests passed ✅🏷️ Commit: 85af170 Learn more about TestLens at testlens.app. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #246
module("org.lwjgl:lwjgl-glfw|", "org.lwjgl.glfw")- matches only the Jar without classifier (new behavior)module("org.lwjgl:lwjgl-glfw", "org.lwjgl.glfw")- matches all Jars not matched by previous rule (restores behavior of versions before 1.14.1)