refactor: use discriminated and packed types from generation#1201
Merged
refactor: use discriminated and packed types from generation#1201
Conversation
spaenleh
approved these changes
Feb 13, 2026
Member
spaenleh
left a comment
spaenleh
left a comment
There was a problem hiding this comment.
Looks good !
I was having a bit of trouble understanding the difference between PackedItem Item and GenericItem.
If I am correct:
PackedItemandItemare the discriminated variants (with one being packed)GenericItemis the "not-discriminated" version ?
I hope we can make the differences clearer ... maybe not now, but something to keep in mind maybe ?
added 7 commits
February 17, 2026 11:56
pyphilia
force-pushed
the
remove-unused-hooks
branch
from
18cfe87 to
8df048f
Compare
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 17, 2026
* refactor: remove unused hooks * refactor: use packed item from generation * refactor: use item as much as possible * refactor: rename types based on generation * refactor: fix tests * refactor: refactor import * refactor: apply changes --------- Co-authored-by: kim <kim.phanhoang@epfl.ch>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the backend returns discriminated generated types
ItemandPackedItem, I've changed the codebase to use these types directly.Itemis the discriminated simple item.GenericItemis the base non-discriminated item.