Adds CTS test coverage for the snorm10-10-10-2 vertex format. - #4695
Open
wangra-google wants to merge 1 commit into
Open
Adds CTS test coverage for the snorm10-10-10-2 vertex format.#4695wangra-google wants to merge 1 commit into
snorm10-10-10-2 vertex format.#4695wangra-google wants to merge 1 commit into
Conversation
* Adds `snorm10-10-10-2` to `kVertexFormatInfo` in `capability_info.ts` (with an explicit cast until `@webgpu/types` is updated). * Adds signed 10-10-10-2 bit-packing (`makeRgb10a2Signed`) and normalization (`normalizeRgb10a2Signed`) test helpers. * Adds packed format test data in `correctness.spec.ts` to verify conversion from raw vertex data to `vec4<f32>` in the vertex shader. Issue: gpuweb/gpuweb#6292 <hr> **Requirements for PR author:** - [x] All missing test coverage is tracked with "TODO" or `.unimplemented()`. - [x] New helpers are `/** documented */` and new helper files are found in `helper_index.txt`. - [x] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.) - [x] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.) **Requirements for [reviewer sign-off](https://github.com/gpuweb/cts/blob/main/docs/reviews.md):** - [ ] Tests are properly located. - [ ] [Test descriptions](https://github.com/gpuweb/cts/blob/main/docs/intro/plans.md) are accurate and complete. - [ ] Tests provide complete coverage (including validation control cases). **Missing coverage MUST be covered by TODOs.** - [ ] Tests avoid [over-parameterization](https://github.com/gpuweb/cts/blob/main/docs/organization.md#parameterization) (see case count report). When landing this PR, be sure to make any necessary issue status updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
snorm10-10-10-2tokVertexFormatInfoincapability_info.ts(with an explicit cast until@webgpu/typesis updated).makeRgb10a2Signed) and normalization (normalizeRgb10a2Signed) test helpers.correctness.spec.tsto verify conversion from raw vertex data tovec4<f32>in the vertex shader.Issue: gpuweb/gpuweb#6292
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.