Skip to content

Test using 0 as the override value of @subgroup_size#4678

Merged
Jiawei-Shao merged 1 commit into
gpuweb:mainfrom
Jiawei-Shao:test-subgroup-size-0
Jul 1, 2026
Merged

Test using 0 as the override value of @subgroup_size#4678
Jiawei-Shao merged 1 commit into
gpuweb:mainfrom
Jiawei-Shao:test-subgroup-size-0

Conversation

@Jiawei-Shao

Copy link
Copy Markdown
Collaborator

This patch adds a regression test that uses 0 as the override value of @subgroup_size for Dawn.

Issue: #4640


Requirements for PR author:

  • [*] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [*] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [*] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • [*] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

This patch adds a regression test that uses 0 as the override value
of `@subgroup_size` for Dawn.
@Jiawei-Shao Jiawei-Shao requested review from Kangz and kainino0x July 1, 2026 06:21
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Results for build job (at bd2b1ce):

-webgpu:shader,validation,extension,subgroup_size_control:subgroup_size_override_must_be_power_of_2_at_pipeline_creation:* - 7 cases, 7 subcases (~1/case)
+webgpu:shader,validation,extension,subgroup_size_control:subgroup_size_override_must_be_power_of_2_at_pipeline_creation:* - 8 cases, 8 subcases (~1/case)
-TOTAL: 283186 cases, 2326094 subcases
+TOTAL: 283187 cases, 2326095 subcases

@Jiawei-Shao Jiawei-Shao merged commit 1aae594 into gpuweb:main Jul 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants