Skip to content

Check that an unused, destroyed occlusion query causes submit to fail #4639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kangz merged 1 commit into from
Apr 29, 2026
Merged

Check that an unused, destroyed occlusion query causes submit to fail #4639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/webgpu/api/validation/queue/destroyed/query_set.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,21 @@ Tests that use a destroyed query set in occlusion query on render pass encoder.
encoder.validateFinishAndSubmitGivenState(t.params.querySetState);
});

g.test('unusedOcclusionQuery')
.desc(
`
Tests that use a destroyed query set in occlusion query on render pass encoder, even if no beginOcclusionQuery calls are done.
- x= {destroyed, not destroyed (control case)}
`
)
.paramsSubcasesOnly(u => u.combine('querySetState', ['valid', 'destroyed'] as const))
.fn(t => {
const occlusionQuerySet = vtu.createQuerySetWithState(t, t.params.querySetState);

const encoder = t.createEncoder('render pass', { occlusionQuerySet });
encoder.validateFinishAndSubmitGivenState(t.params.querySetState);
});

g.test('timestamps')
.desc(
`
Expand Down
1 change: 1 addition & 0 deletions src/webgpu/listing_meta.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,6 +734,7 @@
"webgpu:api,validation,queue,destroyed,query_set:beginOcclusionQuery:*": { "subcaseMS": 17.401 },
"webgpu:api,validation,queue,destroyed,query_set:resolveQuerySet:*": { "subcaseMS": 16.401 },
"webgpu:api,validation,queue,destroyed,query_set:timestamps:*": { "subcaseMS": 0.901 },
"webgpu:api,validation,queue,destroyed,query_set:unusedOcclusionQuery:*": { "subcaseMS": 8.855 },
"webgpu:api,validation,queue,destroyed,texture:beginRenderPass:*": { "subcaseMS": 0.350 },
"webgpu:api,validation,queue,destroyed,texture:copyBufferToTexture:*": { "subcaseMS": 16.550 },
"webgpu:api,validation,queue,destroyed,texture:copyTextureToBuffer:*": { "subcaseMS": 15.900 },
Expand Down
Loading