[github] Fix checkout of PR base commit in pr.yml#4601
Merged
kainino0x merged 1 commit intogpuweb:mainfrom Feb 20, 2026
Merged
Conversation
8 tasks
f31904b to
648a6c2
Compare
648a6c2 to
14a756c
Compare
14a756c to
ba7982f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make the case-count report work better.
It was checking out the latest version of
maininstead of themain-branch commit that GitHub picked as the base commit when creating its temporary merge commit to run the action. This can be different (e.g. if themainbranch changes while the tests are running, though I'm not sure if that's what actually happened in the run where I encountered this issue). Fix this by only fetching once, and using the exact commit that the merge was based off.Issue: none
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.