Skip to content

Comments

[github] Fix checkout of PR base commit in pr.yml#4601

Merged
kainino0x merged 1 commit intogpuweb:mainfrom
kainino0x:branchpoint
Feb 20, 2026
Merged

[github] Fix checkout of PR base commit in pr.yml#4601
kainino0x merged 1 commit intogpuweb:mainfrom
kainino0x:branchpoint

Conversation

@kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Feb 20, 2026

This should make the case-count report work better.

It was checking out the latest version of main instead of the main-branch commit that GitHub picked as the base commit when creating its temporary merge commit to run the action. This can be different (e.g. if the main branch changes while the tests are running, though I'm not sure if that's what actually happened in the run where I encountered this issue). Fix this by only fetching once, and using the exact commit that the merge was based off.

Issue: none


Requirements for PR author:

  • [n/a] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [n/a] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [n/a] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • [n/a] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • [n/a] Tests are properly located.
  • [n/a] Test descriptions are accurate and complete.
  • [n/a] Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • [n/a] Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@kainino0x kainino0x marked this pull request as draft February 20, 2026 02:13
@github-actions
Copy link

github-actions bot commented Feb 20, 2026

Results for build job (at ba7982f):

 Test case/subcase counts did not change.

@kainino0x kainino0x force-pushed the branchpoint branch 16 times, most recently from f31904b to 648a6c2 Compare February 20, 2026 05:15
@kainino0x kainino0x marked this pull request as ready for review February 20, 2026 05:16
@kainino0x kainino0x merged commit 3a8f51b into gpuweb:main Feb 20, 2026
1 check passed
@kainino0x kainino0x deleted the branchpoint branch February 20, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant