refactor(cuda & rocm): bump vllm to v0.20.2#157
Conversation
Signed-off-by: gitlawr <lawrleegle@gmail.com>
Match the workflow behavior in .github/workflows/pack.yml: when pack/<backend>/Dockerfile.<service> exists, use it instead of the backend's main Dockerfile. Signed-off-by: gitlawr <lawrleegle@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the vLLM version from 0.20.1 to 0.20.2 across the project's Dockerfiles and build matrix configuration. It also modifies the Makefile to use the JOB_DOCKERFILE variable for specifying Dockerfile paths, allowing for more flexible build configurations. I have no feedback to provide.
There was a problem hiding this comment.
Pull request overview
Updates the container packaging configuration to build vLLM images against vLLM v0.20.2 for both AMD ROCm and NVIDIA CUDA, aligning default Dockerfile args and the build matrix; also fixes the packaging build to honor service-specific Dockerfiles.
Changes:
- Bump vLLM base image tags and
VLLM_VERSIONfrom0.20.1to0.20.2for ROCm and CUDA packaging. - Update
pack/matrix.yamlbuild args to use the v0.20.2 images across ROCm and CUDA variants. - Make
make packageuse the computed service-specific Dockerfile path (Dockerfile.<service>) when present.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pack/rocm/Dockerfile.vllm | Bumps default vLLM base image/version args to v0.20.2 for ROCm builds. |
| pack/cuda/Dockerfile.vllm | Bumps default vLLM base image/version args to v0.20.2 for CUDA builds. |
| pack/matrix.yaml | Updates matrix build args to vLLM 0.20.2 and corresponding base image tags. |
| Makefile | Uses JOB_DOCKERFILE so packaging builds can select Dockerfile.<service> when available. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - "linux/amd64" | ||
| args: | ||
| - "ROCM_VERSION=7.2.1" | ||
| - "VLLM_VERSION=0.20.1" | ||
| - "VLLM_BASE_IMAGE=vllm/vllm-openai-rocm:v0.20.1" | ||
| - "VLLM_VERSION=0.20.2" | ||
| - "VLLM_BASE_IMAGE=vllm/vllm-openai-rocm:v0.20.2" |
No description provided.