Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ Suggests:
stringr,
devtools,
covr,
bit64
bit64,
withr
RoxygenNote: 7.3.2
Roxygen: list(markdown = TRUE)
VignetteBuilder: knitr
Expand Down
2 changes: 1 addition & 1 deletion R/identify.R
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ identify_differences <- function(
x = BASE,
y = COMP,
by = KEYS,
suffix = c(".x", ".y"),
suffixes = c(".x", ".y"),
sort = TRUE
)
if (nrow(DAT) == 0) {
Expand Down
34 changes: 34 additions & 0 deletions tests/testthat/test-miscellaneous.R
Original file line number Diff line number Diff line change
Expand Up @@ -252,3 +252,37 @@ test_that("datetimes compare as expected", {
print(res)
)
})


testthat::test_that("#138 - No partial arg matches", {
withr::local_options(
list(
warnPartialMatchArgs = TRUE,
warnPartialMatchDollar = TRUE,
warnPartialMatchAttr = TRUE
)
)

df1 <- data.frame(
index1 = c(0, 0, 1, 1),
index2 = c(1, 2, 1, 2),
value = c(1, 2, 3, 4),
value2 = c(1, 2, 3, 4)
)

df2 <- data.frame(
index1 = c(1, 1, 2, 2),
index2 = c(1, 2, 1, 2),
value = c(0, 1, 20, 3),
value2 = c(0, 1, 2, 333)
)

expect_no_condition({
diff_result <- diffdf::diffdf(
df1,
df2,
keys = c("index1", "index2"),
suppress_warnings = TRUE
)
})
})
Loading