Update exit page controller to use new-style exit pages - #2283
Merged
Conversation
lfdebrux
force-pushed
the
ldeb-new-style-exit-pages
branch
from
August 12, 2026 09:28
a2abf06 to
c11cfa5
Compare
lfdebrux
marked this pull request as draft
August 12, 2026 09:28
lfdebrux
force-pushed
the
ldeb-new-style-exit-pages
branch
3 times, most recently
from
August 12, 2026 10:06
dfaf3f2 to
e25cb26
Compare
lfdebrux
marked this pull request as ready for review
August 12, 2026 10:12
theseanything
left a comment
theseanything
left a comment
Contributor
There was a problem hiding this comment.
To minor comments - but generally looks fine!
lfdebrux
force-pushed
the
ldeb-new-style-exit-pages
branch
from
August 12, 2026 13:52
e25cb26 to
1d199d5
Compare
Add some checks/exceptions for various possible edge cases to the exit_page#show action: - If the step does not have an exit page, redirect to the next visitable step - If the answer given for the step does not route to an exit page, redirect to the next visitable step - If the form document is missing the exit page object in the step for some reason (this shouldn't happen), raise an exception
lfdebrux
force-pushed
the
ldeb-new-style-exit-pages
branch
from
August 13, 2026 05:14
1d199d5 to
e26927a
Compare
Contributor
|
🎉 A review copy of this PR has been deployed! It is made of up two components It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
theseanything
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/0ijhpyt8/3146-update-forms-runner-to-work-with-more-than-one-exit-page-for-a-question
This PR updates the
exit_page#showaction to work with new-style exit pages. The code still assumes that an question with an exit page has only one exit page and only one routing condition, but this PR does most of the changes needed to make the exit page controller work with multiple exit pages. We just need to make some more changes to the step model and the step controller before we can fully support more than one exit page per question in forms-runner.Things to consider when reviewing