Skip to content

remove aws-ses prefix from runner classes. - #2273

Draft
alice-carr wants to merge 1 commit into
mainfrom
remove-awsses-prefix
Draft

remove aws-ses prefix from runner classes.#2273
alice-carr wants to merge 1 commit into
mainfrom
remove-awsses-prefix

Conversation

@alice-carr

Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

We have recently switched to using ses for confirmation emails from notify. Since we are now only using one mail delivery method, we do no need to specify that they are using ses.

Trello card: https://trello.com/c/GfBTJbNL/3154-use-ses-to-send-all-confirmation-emails

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@alice-carr
alice-carr force-pushed the remove-awsses-prefix branch from 7afc9b0 to 9fbd2fa Compare August 11, 2026 14:56
We have recently switched to using ses for confirmation emails from notify. Since we are now only using one mail delivery method, we do no need to specify that they are using ses.
@alice-carr
alice-carr force-pushed the remove-awsses-prefix branch from 9fbd2fa to f61c800 Compare August 11, 2026 15:44
@github-actions

Copy link
Copy Markdown
Contributor

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant