Add default S3 submission role ARN for local development - #2269
Open
lfdebrux wants to merge 2 commits into
Open
Conversation
When assuming the development readonly role in AWS, the role session name is derived from the UNIX username, for information purposes. However, when running forms-runner in a Docker container, the $USER is always `ruby`, which isn't very informative. This commit adds code to get the user name from $AWS_USER, if it is set. This is not normally set, but a future PR in forms-deploy will update the Docker Compose configuration for running forms locally to set it.
When running forms-runner locally, we want to be able to test S3 submissions. Using the `ASSUME_DEV_IAM_ROLE` flag allows that, but only when the S3 submissions role in the development environment is also provided. The role ARN is defined in forms-deploy [[1]], but using it locally is not well documented. This commit adds the role ARN to the default configuration for local development. This should make it possible to test S3 submissions just by using the `ASSUME_DEV_IAM_ROLE` feature without further configuration. [1]: https://github.com/govuk-forms/forms-deploy/blob/a12f9395bf84e9e66ea458b396f7867ce4c9f84d/infra/modules/forms-runner/submissions-to-s3.tf#L2
lfdebrux
force-pushed
the
ldeb-add-s3-submission-iam-role-arn
branch
from
August 6, 2026 10:15
418e517 to
d2722f7
Compare
Contributor
|
🎉 A review copy of this PR has been deployed! It is made of up two components It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
When running forms-runner locally, we want to be able to test S3 submissions. Using the
ASSUME_DEV_IAM_ROLEflag allows that, but only when the S3 submissions role in the development environment is also provided. The role ARN is defined in forms-deploy [1], but using it locally is not well documented.This commit adds the role ARN to the default configuration for local development. This should make it possible to test S3 submissions just by using the
ASSUME_DEV_IAM_ROLEfeature without further configuration.Things to consider when reviewing