update confirmation email test to use SES rather than notify - #324
Merged
Conversation
alice-carr
marked this pull request as draft
August 4, 2026 14:49
alice-carr
force-pushed
the
use-ses-for-confirmation-email
branch
from
August 10, 2026 09:53
85b86fe to
ce92598
Compare
alice-carr
marked this pull request as ready for review
August 10, 2026 10:52
theseanything
previously approved these changes
Aug 10, 2026
stephencdaly
requested changes
Aug 10, 2026
alice-carr
force-pushed
the
use-ses-for-confirmation-email
branch
2 times, most recently
from
August 10, 2026 13:51
cd1382f to
0c22c6b
Compare
alice-carr
force-pushed
the
use-ses-for-confirmation-email
branch
5 times, most recently
from
August 11, 2026 13:50
8b17561 to
3a216e9
Compare
we are switching from using notify to send confirmation emails to using SES - this will keep it in line with the copy of answers feature. This commit updates the end to end tests so that they now check s3 rather than notify for the confirmation email.
alice-carr
force-pushed
the
use-ses-for-confirmation-email
branch
from
August 11, 2026 13:53
3a216e9 to
13ce33d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
we are switching from using notify to send confirmation emails to using SES - this will keep it in line with the copy of answers feature.
This pr updates the end to end tests so that they now check s3 rather than notify for the confirmation email. This includes adding a new confirmation email that has already been set up in ses.
Trello card: https://trello.com/c/GfBTJbNL/3154-use-ses-to-send-all-confirmation-emails
Things to consider when reviewing
you can review this by running the e2e tests against the forms-runner branch:
use-ses-to-send-all-confirmation-emails