Update FormDocumentSyncService for new unique indexes - #3023
Merged
Conversation
We're not yet updating the service to increment the version number when a form goes live. However, we need to update the service to handle the new unique indexes we want to add that will enforce that there is only one form document per version per language for a form. Ensure we delete archived form documents before creating a new live form document so we only ever have one live or archived form document per language per form. We also don't need to handle the case where there is an existing archived form document when archiving a form, as this can never happen and will soon be enforced by the new unique indexes.
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3023.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
theseanything
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/dGv0TrD1
We're not yet updating the service to increment the version number when a form goes live.
However, we need to update the service to handle the new unique indexes we want to add that will enforce that there is only one form document per version per language for a form.
Ensure we delete archived form documents before creating a new live form document so we only ever have one live or archived form document per language per form.
We also don't need to handle the case where there is an existing archived form document when archiving a form, as this can never happen and will soon be enforced by the new unique indexes.
I've verified that no existing form has both live and archived form documents for the same language on any environment using the query:
SELECT form_id from form_documents where tag IN ('live', 'archived') group by form_id, language having count(1) > 1;Things to consider when reviewing