Add branding attributes to brands - #3019
Merged
Merged
Conversation
theseanything
force-pushed
the
add-branding-attributes-to-brands
branch
9 times, most recently
from
August 12, 2026 15:15
b842bfe to
caaef4b
Compare
The runner keeps each brand's styling and organisation details in a static branding.yml file, so changing a brand's colours or details means a code change. Brands in forms-admin only store a name and slug. Add background colour, border colour, organisation name, organisation URL and copyright holder columns to brands. All five attributes are required, colours must be lowercase six digit hex codes and the organisation URL must start with http:// or https://. Permit the new attributes in the brands controller so they can be set on create and update.
The seeded brands were named after real councils, which could be mistaken for genuine data in local and review environments. They also had no values for the new branding attributes, which are now required. Replace them with obviously fictional councils and give them values for every branding attribute.
Brands now store colours and organisation details, but there was no way to see or change them in the interface. Add fields for the new attributes to the new and edit brand forms, with hint text showing the expected hex colour format, and list the attributes on the brand details page.
The runner fetches brand configuration from the brands API but only receives the name and slug, so it still has to look up colours and organisation details in its local branding.yml file. Include the branding attributes in the API response so the runner can use them instead of its static configuration.
theseanything
force-pushed
the
add-branding-attributes-to-brands
branch
from
August 12, 2026 15:52
caaef4b to
e029d95
Compare
theseanything
marked this pull request as ready for review
August 12, 2026 15:54
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-3019.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
stephencdaly
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runner keeps each brand's styling and organisation details in a static branding.yml file, so changing a brand's appearance means a code change and a deploy. Brands in forms-admin only store a name and slug.
This stores the branding attribute on the brands model, so super admins can manage them. This gets us a step closer to switch runner to using the brands API instead of its static configuration.
Image assets (logo, favicon, opengraph) are not included for now and will address once we serve assets from S3.
govuk-forms/forms-deploy#2192