feat: #1007 - Option to disable local login when OIDC is enabled - #1020
Merged
jmattheis merged 1 commit intoAug 13, 2026
Conversation
jmattheis
requested changes
Aug 5, 2026
jmattheis
left a comment
Member
There was a problem hiding this comment.
Looks good so far. I've some remarks and haven't tested it manually.
jmattheis
reviewed
Aug 6, 2026
jmattheis
left a comment
Member
There was a problem hiding this comment.
I've made some small fixes.
I'll test this some more and will merge it around end of next week. (For security related stuff I want to take my time and I'm currently a bit busy).
Contributor
Author
|
No worries, take your time, there's no rush |
jmattheis
force-pushed
the
github_1007_option_to_disable_local_login_when_oidc_enabled
branch
from
August 13, 2026 18:41
68b1976 to
529f75e
Compare
jmattheis
force-pushed
the
github_1007_option_to_disable_local_login_when_oidc_enabled
branch
from
August 13, 2026 18:48
529f75e to
795d9d1
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1020 +/- ##
==========================================
+ Coverage 74.28% 74.63% +0.34%
==========================================
Files 66 66
Lines 3512 3532 +20
==========================================
+ Hits 2609 2636 +27
+ Misses 698 690 -8
- Partials 205 206 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to implement #1007
Adds configurable local authentication through GOTIFY_LOCALAUTH_ENABLED, defaults to true to preserve existing behavior.
When local authentication is disabled:
The server exits with a fatal error when both local authentication and OIDC are disabled, preventing startup without an available login method.