update App.js and package.json to react-router-dom v6.3.0#2
Open
jeffmjack wants to merge 1 commit intogopinav:masterfrom
Open
update App.js and package.json to react-router-dom v6.3.0#2jeffmjack wants to merge 1 commit intogopinav:masterfrom
jeffmjack wants to merge 1 commit intogopinav:masterfrom
Conversation
MustafaN2028
approved these changes
Jun 15, 2023
MustafaN2028
approved these changes
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Vishwas!
When I ran
npx create-react-appand followed along with React Query Tutorial 2: Project Setup, I had to fix the markup inApp.jsto work withreact-router-dom v6.3.0before the pages would render, figured I'd pass this along in case it is helpful to you!I tested this by running the two servers and poking around, things all seem to work.
I'm a huge fan of your work and would be happy to help with other stuff if you ever need it!
Jeff