Skip to content

fix(gmail): handle message headers case-insensitively#693

Open
jeevan6996 wants to merge 1 commit intogoogleworkspace:mainfrom
jeevan6996:fix/642-gmail-header-case-insensitive
Open

fix(gmail): handle message headers case-insensitively#693
jeevan6996 wants to merge 1 commit intogoogleworkspace:mainfrom
jeevan6996:fix/642-gmail-header-case-insensitive

Conversation

@jeevan6996
Copy link
Copy Markdown

Summary

  • update parse_message_headers to match header names case-insensitively, aligning behavior with RFC semantics and existing helper logic
  • ensure reply/reply-all keeps recipients and threading metadata even when headers arrive as FROM/TO/CC or mixed-case variants
  • add a regression test that exercises mixed-case From/Reply-To/To/Cc/Date/Message-ID/References headers
  • include a patch changeset for release automation

Fixes #642

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 9, 2026

🦋 Changeset detected

Latest commit: 08a4db7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@googleworkspace/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@googleworkspace-bot googleworkspace-bot added the area: core Core CLI parsing, commands, error handling, utilities label Apr 9, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the robustness of Gmail message header parsing by implementing case-insensitive matching. This change ensures that critical metadata, such as sender information and threading references, is correctly extracted even when headers are provided in non-standard casing, aligning the implementation with RFC standards.

Highlights

  • Case-Insensitive Header Parsing: Updated the message header parsing logic to normalize header names to lowercase, ensuring consistent handling regardless of the original casing.
  • Regression Testing: Added a comprehensive test case to verify that mixed-case headers are correctly processed, preserving recipient and threading metadata.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Apr 9, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Gmail message header parsing logic to be case-insensitive by converting header names to lowercase before matching. This ensures that headers like 'FROM' or 'Message-Id' are correctly identified regardless of their casing. Additionally, a new test case has been added to verify this behavior across various header names and casing styles. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Core CLI parsing, commands, error handling, utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(gmail): parse_message_headers uses case-sensitive match, drops CC/headers with non-canonical casing

2 participants