Skip to content

fix: output compact JSON errors for NDJSON streams#692

Open
jeevan6996 wants to merge 1 commit intogoogleworkspace:mainfrom
jeevan6996:fix/680-ndjson-error-output
Open

fix: output compact JSON errors for NDJSON streams#692
jeevan6996 wants to merge 1 commit intogoogleworkspace:mainfrom
jeevan6996:fix/680-ndjson-error-output

Conversation

@jeevan6996
Copy link
Copy Markdown

@jeevan6996 jeevan6996 commented Apr 9, 2026

Summary

  • switch print_error_json to compact JSON so stdout stays line-delimited and NDJSON-compatible
  • add a small helper for error JSON serialization and a unit test verifying output is single-line valid JSON
  • add a patch changeset per repo policy

Fixes #680

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 9, 2026

🦋 Changeset detected

Latest commit: 123b8f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@googleworkspace/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the CLI error reporting mechanism to output compact, single-line JSON instead of pretty-printed JSON. This change ensures that error messages do not break the structure of NDJSON streams, maintaining compatibility for tools that consume line-delimited output.

Highlights

  • Compact JSON Output: Switched CLI error reporting from pretty-printed JSON to compact, single-line JSON to ensure compatibility with NDJSON streams.
  • Helper Implementation: Introduced a new helper function error_json_line to handle the serialization of errors into a single-line format.
  • Verification: Added a unit test to verify that error output remains valid, single-line JSON.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Apr 9, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@googleworkspace-bot googleworkspace-bot added the area: core Core CLI parsing, commands, error handling, utilities label Apr 9, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the CLI error output to ensure NDJSON compatibility by switching from pretty-printed JSON to compact, single-line JSON. It introduces a new helper function error_json_line and includes a unit test to verify the compact format. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Core CLI parsing, commands, error handling, utilities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Watch/subscribe commands output pretty-printed JSON errors instead of NDJSON

2 participants