feat: expose info window customization for advanced markers - #965
Open
kikoso wants to merge 2 commits into
Open
Conversation
AdvancedMarkerImpl already supported customizing a marker's info window via infoWindow/infoContent, wiring them into MarkerNode correctly, but the public AdvancedMarker composable never exposed those parameters. Add AdvancedMarkerInfoWindow and AdvancedMarkerInfoWindowContent, mirroring the existing MarkerInfoWindow/MarkerInfoWindowContent public API for regular markers. Fixes #822
Contributor
Code Coverage
|
Demonstrates the new public API from #822 by using it for Marker 1 in AdvancedMarkersActivity.
kikoso
marked this pull request as ready for review
August 14, 2026 15:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AdvancedMarkerImpl(the private implementation backingAdvancedMarker) already fully supported customizing a marker's info window viainfoWindow/infoContentparameters, wiring them correctly intoMarkerNode. However, the publicAdvancedMarkercomposable never exposed these parameters, so there was no way to use this from outside the library.MarkerInfoWindow/MarkerInfoWindowContent):AdvancedMarkerInfoWindow— customize the entire info windowAdvancedMarkerInfoWindowContent— customize just the info window's content, keeping the default frameAdvancedMarkerpublic API — purely additive.Fixes #822
Test plan
testAdvancedMarkerInfoWindowContentDoesNotCrashandtestAdvancedMarkerInfoWindowDoesNotCrashtoGoogleMapViewTests. Note: custom info window content is rendered to a bitmap byComposeInfoWindowAdapter(not present in the Compose semantics tree), so these assert the composables wire up andshowInfoWindow()succeeds without crashing, rather than asserting on-screen content.GoogleMapViewTestson a physical device (Pixel 4, API 33): all 18 tests pass.