feat: Maps 3D Compose Wrapper and Samples by dkhawk · Pull Request #39 · googlemaps-samples/android-maps3d-samples

dkhawk · 2026-04-14T00:04:33Z

This PR introduces a new Jetpack Compose wrapper for the Maps 3D SDK (GoogleMap3D) and implements several sample activities to demonstrate its usage:

HelloMapActivity: Basic map display.
CameraControlsActivity: Demonstrates camera state hoisting and control.
MapInteractionsActivity: Shows how to handle map clicks and interact with the scene.
MarkersActivity: Demonstrates adding custom markers (like the alien on Devils Tower) with interactive popovers.

Key features added to the wrapper:

Declarative marker support via MarkerConfig.
Support for click listeners on markers returning the native Marker instance for popover anchoring.
Map mode selection.
Steady state callbacks.

All activities are exported in the manifest for direct launching.

…esting

…latirons

…ctivity

…ersActivity

- Added PolylineConfig enhancements (drawsOccludedSegments, onClick). - Created PolylinesActivity with Sanitas Loop demo (double polyline, hovering). - Wired click listener to show Toast via rememberCoroutineScope. - Removed useless MAPS_API_KEY warning from build files.

- Added extruded museum building to PolygonsActivity.kt using a custom extrusion helper. - Added onClick callback to PolygonConfig in DataModels.kt and handled it in Map3DState.kt. - Updated PolygonsActivity.kt to use click listeners on the zoo and museum polygons. - Expanded unit tests in MappersTest.kt to cover default values. - Cleaned up fully qualified names in DataModels.kt. - Added missing imports in PolygonsActivity.kt to resolve compilation errors.

…striction crash - Add MapOptionsActivity to demonstrate map options and camera restrictions. - Add PopoversActivity to demonstrate popovers. - Implement toValidCameraRestriction() extension function to sanitize CameraRestriction parameters. - Provide safe defaults from defined ranges when parameters are null to prevent crashes in the native SDK. - Ensure min <= max for altitude, heading, and tilt by swapping values if necessary. - Refactor GoogleMap3D.kt to use the new extension function. - Update MainActivity and AndroidManifest to include new samples. - Clean up SampleScreens.kt.

…tecture - Moved BasicMapSample to its own file for better modularity. - Implemented ModelsActivity to demonstrate loading 3D models and orchestrating cinematic camera animations. - Registered ModelsActivity in the manifest and updated MainActivity to launch it. - Added unit tests in UtilitiesTest.kt for CameraRestriction validation. - Removed old placeholders from SampleScreens.kt. - Included pre-existing changes in PolylinesActivity and deletion of properties file.

- Refactor "Basic Map with Marker & Polyline" sample to launch BasicMapActivity instead of using inline state. - Create BasicMapActivity and register it in the manifest. - Delete empty SampleScreens.kt file. - Simplify polyline in PolylinesActivity to fix visual test failure. - Increase timeout and add delay in Maps3DVisualTest for map interactions. - Add log in MapInteractionsActivity for debugging clicks. - Fix ktlint violations and clean up unused imports across the project.

…mentation - Implement `PopoverConfig` in `DataModels.kt` to support declarative popovers in Compose. - Add `popovers` parameter and `onMapClick` callback to `GoogleMap3D` composable to enable state-driven popover management and map interaction. - Implement `syncPopovers` in `Map3DState.kt` to handle the mapping between Compose configurations and native SDK Popover instances. - Refactor `PopoversActivity` in `maps3d-compose-demo` to demonstrate the declarative API, setting `autoPanEnabled` and `autoCloseEnabled` to false for predictable, state-driven UI behavior. - Add `README.md` files to both `maps3d-compose` and `maps3d-compose-demo` modules to clarify their purpose as reference implementations. - Relocate and expand `compose_api_coverage.md` into a comprehensive checklist tracking specific SDK classes and listeners, highlighting unsupported features like `Map3DViewUiController`. - Update root `README.md` to document the new modules with explicit warnings about their experimental nature.

kikoso · 2026-04-15T19:01:27Z

+        modifier = modifier,
+        factory = { context ->
+            val map3dView = Map3DView(context, options)
+            map3dView.onCreate(null)


I am thinking if adding this would make sure we can restore the state about reconfiguration changes:

Suggested change

map3dView.onCreate(null)

map3dView.onCreate(LocalSavedStateRegistryOwner.current )

kikoso · 2026-04-15T19:02:56Z

+            map3dView
+        },
+        update = { map3dView ->
+            map3dView.getMap3DViewAsync(object : OnMap3DViewReadyCallback {


We are calling this on every recomposition. What about calling it on the factory() lambda?

kikoso · 2026-04-15T19:04:17Z

+ */
+class GeminiVisualTestHelper {
+
+    private val client = HttpClient(CIO) {


This is never closed. I am not sure if something like https://developer.android.com/reference/java/lang/AutoCloseable could help.

kikoso · 2026-04-15T19:04:46Z

+
+    private val client = HttpClient(CIO) {
+        install(HttpTimeout) {
+            requestTimeoutMillis = 60000


The nittest of the nits:

Suggested change

requestTimeoutMillis = 60000

requestTimeoutMillis = 60_000

kikoso · 2026-04-15T19:04:53Z

+    private val client = HttpClient(CIO) {
+        install(HttpTimeout) {
+            requestTimeoutMillis = 60000
+            connectTimeoutMillis = 60000


Suggested change

connectTimeoutMillis = 60000

connectTimeoutMillis = 60_000

kikoso · 2026-04-15T19:05:00Z

+        install(HttpTimeout) {
+            requestTimeoutMillis = 60000
+            connectTimeoutMillis = 60000
+            socketTimeoutMillis = 60000


Suggested change

socketTimeoutMillis = 60000

socketTimeoutMillis = 60_000

kikoso · 2026-04-15T19:17:14Z

+        helper.performActionFromPrompt("Click the CLUSTERING button", uiDevice, geminiApiKey)
+
+        // Wait for the clustering screen to load and map to render
+        TimeUnit.SECONDS.sleep(5)


Does the onMapSteadyListener could work here?

…40) * feat: Implement OnCameraChangedListener and add Whiskey Compass demo - Exposed onCameraChanged callback in GoogleMap3D composable. - Added WhiskeyCompass composable in demo app. - Added CameraChangedActivity to demonstrate camera changes with compass, tilt scale, and range scale. - Updated compose_api_coverage.md. * docs: Add code reference link for OnCameraChangedListener in coverage doc * refactor: Move camera changed demo widgets to widgets package - Moved WhiskeyCompass.kt to widgets package. - Extracted TiltScale and RangeScale to separate files in widgets package. - Updated CameraChangedActivity to use widgets from the new package.

* feat: Implement OnCameraChangedListener and add Whiskey Compass demo - Exposed onCameraChanged callback in GoogleMap3D composable. - Added WhiskeyCompass composable in demo app. - Added CameraChangedActivity to demonstrate camera changes with compass, tilt scale, and range scale. - Updated compose_api_coverage.md. * docs: Add code reference link for OnCameraChangedListener in coverage doc * refactor: Move camera changed demo widgets to widgets package - Moved WhiskeyCompass.kt to widgets package. - Extracted TiltScale and RangeScale to separate files in widgets package. - Updated CameraChangedActivity to use widgets from the new package. * feat: Implement PinConfiguration support and add visual test * docs: Update API coverage for PinConfiguration * docs: Clean up compose coverage file * docs: Remove supported items from Not Yet Exposed list * docs: Remove PinView from coverage checklist * feat: Implement OnPlaceClickListener support and add visual test * docs: Remove unsupported APIs from coverage checklist

kikoso · 2026-04-16T16:28:42Z

+    alias(libs.plugins.kotlin.android)
+    alias(libs.plugins.kotlin.compose)
+    alias(libs.plugins.secrets.gradle.plugin)
+    id("com.diffplug.spotless") version "6.25.0"


Could this be moved to the catalog?

dkhawk added 15 commits April 13, 2026 16:42

feat: Implement Maps 3D Compose wrapper, sample catalog, and visual t…

6dd161d

…esting

feat: Implement Hello Map sample as a separate activity centered on F…

403066e

…latirons

feat: Switch Hello Map location to Delicate Arch and fix visual test

2a2fc84

feat: Calibrate camera pose for Delicate Arch in HelloMapActivity

d6560b0

chore: Add visual test examples and gradle daemon properties

3830272

feat: Add Camera Controls activity and calibrate for Seattle

80b110f

feat: Add Map Interactions sample calibrated for Denver Capitol

11e1d5e

refactor: Reorder parameters in GoogleMap3D to follow Compose convention

3cf36b8

test: Use conventional UiAutomator testing for Map Interactions fallback

f5c9160

test: Verify Markers sample with visual test

8a1c759

test: Verify Markers sample with popover and extruded marker

365d86f

feat: Export all sample activities in manifest

c527626

feat: Remove unnecessary Back buttons from sample activities

4bf0664

feat: Support onClick callback in MarkerConfig and use it in MarkersA…

1c06045

…ctivity

refactor: Clean up fully qualified class names in DataModels and Mark…

29699c1

…ersActivity

dkhawk marked this pull request as draft April 14, 2026 00:04

dkhawk added 8 commits April 14, 2026 11:03

fix: Remove extra brace in build.gradle.kts files

0c91270

build: Add installAndLaunch task to maps3d-compose-demo

e570288

dkhawk requested a review from kikoso April 14, 2026 21:14

dkhawk marked this pull request as ready for review April 14, 2026 21:14

kikoso reviewed Apr 15, 2026

View reviewed changes

dkhawk added 2 commits April 15, 2026 17:16

kikoso reviewed Apr 16, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Maps 3D Compose Wrapper and Samples#39

feat: Maps 3D Compose Wrapper and Samples#39
dkhawk wants to merge 25 commits intomainfrom
feat/new-compose-wrapper

dkhawk commented Apr 14, 2026

Uh oh!

kikoso Apr 15, 2026 •

edited

Loading

Uh oh!

kikoso Apr 15, 2026

Uh oh!

kikoso Apr 15, 2026

Uh oh!

kikoso Apr 15, 2026

Uh oh!

kikoso Apr 15, 2026

Uh oh!

kikoso Apr 15, 2026

Uh oh!

kikoso Apr 15, 2026

Uh oh!

kikoso Apr 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	map3dView.onCreate(null)
	map3dView.onCreate(LocalSavedStateRegistryOwner.current )

Conversation

dkhawk commented Apr 14, 2026

Uh oh!

kikoso Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kikoso Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

kikoso Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

kikoso Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

kikoso Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

kikoso Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

kikoso Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

kikoso Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kikoso Apr 15, 2026 •

edited

Loading