Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/snippets/requirements-test.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
pytest===7.4.4; python_version == '3.7'
pytest==8.3.5; python_version >= '3.8'
pytest==9.0.2; python_version >= '3.8'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

pytest 9.x requires Python 3.10 or newer, but this line attempts to install it for Python 3.8 and 3.9 as well, which will cause your build to fail for those versions. You should restrict this version to Python 3.10+.

To maintain support for older Python versions in your test matrix, you'll also need to add a line for pytest 8.x. Please add the following line before this one:

pytest==8.3.5; python_version >= '3.8' and python_version < '3.10'
pytest==9.0.2; python_version >= '3.10'

mock==5.2.0
backoff==2.2.1
6 changes: 3 additions & 3 deletions samples/snippets/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
google-cloud-pubsub==2.29.0
google-cloud-storage==3.1.0
google-cloud-pubsub==2.35.0
google-cloud-storage==3.9.0
pandas===1.3.5; python_version == '3.7'
pandas===2.0.3; python_version == '3.8'
pandas==2.2.3; python_version >= '3.9'
pandas==3.0.1; python_version >= '3.9'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

pandas 3.x requires Python 3.11 or newer. This line attempts to install it for Python 3.9 and 3.10, which will cause build failures. You should restrict this version to Python 3.11+.

To maintain support for Python 3.9 and 3.10, you should add a line to continue using pandas 2.x for those versions. Please add the following line before this one:

pandas==2.2.3; python_version >= '3.9' and python_version < '3.11'
pandas==3.0.1; python_version >= '3.11'

opentelemetry-exporter-gcp-trace
opentelemetry-propagator-gcp
opentelemetry-instrumentation-requests