Skip to content

fix: send embedding_model as query parameter in fileSearchStores.create#2376

Closed
kausmeows wants to merge 1 commit intogoogleapis:mainfrom
kausmeows:fix/emebedding-model-req
Closed

fix: send embedding_model as query parameter in fileSearchStores.create#2376
kausmeows wants to merge 1 commit intogoogleapis:mainfrom
kausmeows:fix/emebedding-model-req

Conversation

@kausmeows
Copy link
Copy Markdown

PR Description

What the EAP docs say should work:

store = client.file_search_stores.create(
    config={
        "display_name": "Multimodal Catalog",
        "embedding_model": "models/gemini-embedding-2"
    }
)

What the SDK does in v1.75.0 (broken):

The serializer _CreateFileSearchStoreConfig_to_mldev places embeddingModel in the request body: setv(parent_object, ['embeddingModel'], ...)

This sends:

POST /v1beta/fileSearchStores
Body: {"displayName": "...", "embeddingModel": "models/gemini-embedding-2"}

The API rejects it:

image
400 INVALID_ARGUMENT. Invalid JSON payload received.
Unknown name "embeddingModel" at 'file_search_store': Cannot find field.

Seems like a regression from- kausmeows@dd11222 ?

Because as per EAP the API still accepts it as query. With this fix the integration is working in Agno. Had to monkey patch here rn- agno-agi/agno#7788

@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 5, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Venkaiahbabuneelam Venkaiahbabuneelam self-assigned this May 5, 2026
@Venkaiahbabuneelam Venkaiahbabuneelam added the size:S Code changes < 10 lines label May 5, 2026
@kausmeows
Copy link
Copy Markdown
Author

not needed, as the google team decided to keep this and update the API.

@kausmeows kausmeows closed this May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S Code changes < 10 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants