fix: send embedding_model as query parameter in fileSearchStores.create#2376
Closed
kausmeows wants to merge 1 commit intogoogleapis:mainfrom
Closed
fix: send embedding_model as query parameter in fileSearchStores.create#2376kausmeows wants to merge 1 commit intogoogleapis:mainfrom
embedding_model as query parameter in fileSearchStores.create#2376kausmeows wants to merge 1 commit intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
not needed, as the google team decided to keep this and update the API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
What the EAP docs say should work:
What the SDK does in
v1.75.0(broken):The serializer
_CreateFileSearchStoreConfig_to_mldevplacesembeddingModelin the request body:setv(parent_object, ['embeddingModel'], ...)The API rejects it:
Seems like a regression from- kausmeows@dd11222 ?
Because as per EAP the API still accepts it as query. With this fix the integration is working in Agno. Had to monkey patch here rn- agno-agi/agno#7788