fix: support list[pydantic.BaseModel] in response.parsed#2190
Open
Adewale-1 wants to merge 2 commits intogoogleapis:mainfrom
Open
fix: support list[pydantic.BaseModel] in response.parsed#2190Adewale-1 wants to merge 2 commits intogoogleapis:mainfrom
Adewale-1 wants to merge 2 commits intogoogleapis:mainfrom
Conversation
When response_schema is set to list[SomeModel], the response.parsed field was typed as Optional[Union[pydantic.BaseModel, dict, Enum]], which excluded list[pydantic.BaseModel]. This caused type errors and made it impossible to use the parsed field with list schemas. Add list[pydantic.BaseModel] to the Union so response.parsed correctly reflects list-typed schema responses.
…ibility - Remove test_parsed_list_support.py (required live API key; type annotation is already covered by test_parsed_list_mypy.py) - Fix LiveConnectConfig field assertion (model -> generation_config) - Fix LiveClientToolResponse field assertion (function_responses) - Fix test_combined_functionality to use no live API calls - Use model_fields instead of deprecated __fields__
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
response_schemais set tolist[SomeModel], theresponse.parsedfield was typed as
Optional[Union[pydantic.BaseModel, dict, Enum]],which excluded
list[pydantic.BaseModel]. This caused type errors andmade it impossible to use the
parsedfield with list-typed schemas.Changes
list[pydantic.BaseModel]to theparsedfield Union inGenerateContentResponsetest_parsed_list_support.py)test_parsed_list_mypy.py)test_live_client_and_list_type.py)Fixes #886