Skip to content

chore: Extract snapshot tests to different nox session#2274

Closed
TrevorBergeron wants to merge 2 commits intomainfrom
fix_snapshot_stuff
Closed

chore: Extract snapshot tests to different nox session#2274
TrevorBergeron wants to merge 2 commits intomainfrom
fix_snapshot_stuff

Conversation

@TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Nov 17, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: m Pull request size is medium. labels Nov 17, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review November 17, 2025 22:46
@TrevorBergeron TrevorBergeron requested a review from a team as a code owner November 17, 2025 22:46
@TrevorBergeron TrevorBergeron requested review from a team and jialuoo November 17, 2025 22:46
Copy link
Contributor

@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep the snapshot tests as part of the presubmit.

@chalmerlowe
Copy link

Migration Notice: This library is moving to the google-cloud-python monorepo soon.

We closed this PR due to inactivity to ensure a clean migration. Please re-open this work in the new monorepo once the migration is complete!

@chalmerlowe chalmerlowe closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants