Skip to content

fix: GenAI Client(evals) - missing response warning when agent_data is present #6406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 12, 2026
Merged

fix: GenAI Client(evals) - missing response warning when agent_data is present #6406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions vertexai/_genai/_evals_data_converters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,9 +786,11 @@ def merge_evaluation_datasets(

if base_eval_case.responses:
candidate_responses.append(base_eval_case.responses[0])
elif base_eval_case.agent_data:
candidate_responses.append(_create_placeholder_response_candidate(""))
else:
logger.warning(
"No response found for base dataset (index 0) in case %s. "
"No response or agent data found for base dataset (index 0) in case %s. "
"Adding placeholder.",
case_idx,
)
Expand All @@ -807,6 +809,7 @@ def merge_evaluation_datasets(
"system_instruction",
"conversation_history",
"intermediate_events",
"agent_data",
},
exclude_none=True,
)
Expand All @@ -830,16 +833,20 @@ def merge_evaluation_datasets(
"system_instruction",
"conversation_history",
"intermediate_events",
"agent_data",
},
exclude_none=True,
)
eval_case_custom_columns.update(current_ds_extra_attrs)

if current_ds_eval_case.responses:
candidate_responses.append(current_ds_eval_case.responses[0])
elif current_ds_eval_case.agent_data:
candidate_responses.append(_create_placeholder_response_candidate(""))
else:
logger.warning(
"No response found for dataset %s in case %s. Adding placeholder.",
"No response or agent data found for dataset %s in case %s. Adding"
" placeholder.",
dataset_idx_offset,
case_idx,
)
Expand All @@ -854,11 +861,12 @@ def merge_evaluation_datasets(
eval_case_id=base_eval_case.eval_case_id
or "merged_eval_case_%s" % case_idx,
prompt=base_eval_case.prompt,
responses=candidate_responses,
responses=candidate_responses if candidate_responses else None,
reference=base_eval_case.reference,
system_instruction=base_eval_case.system_instruction,
conversation_history=base_eval_case.conversation_history,
agent_info=agent_info,
agent_data=base_eval_case.agent_data,
intermediate_events=base_eval_case.intermediate_events,
**eval_case_custom_columns,
)
Expand Down
Loading