Skip to content

fix: GenAI SDK client - Add get session call to create session sdk if an immediate success is returned #6405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 11, 2026
+24 −16
Merged

fix: GenAI SDK client - Add get session call to create session sdk if an immediate success is returned #6405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/unit/vertexai/genai/replays/test_create_agent_engine_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def test_create_session_with_ttl(client):
config=types.CreateAgentEngineSessionConfig(
display_name="my_session",
session_state={"foo": "bar"},
ttl="120s",
ttl="1200000s",
labels={"label_key": "label_value"},
),
)
Expand All @@ -42,12 +42,13 @@ def test_create_session_with_ttl(client):
assert operation.response.user_id == "test-user-123"
assert operation.response.labels == {"label_key": "label_value"}
assert operation.response.name.startswith(agent_engine.api_resource.name)
assert operation.done
# Expire time is calculated by the server, so we only check that it is
# within a reasonable range to avoid flakiness.
assert (
operation.response.create_time + datetime.timedelta(seconds=119.5)
operation.response.create_time + datetime.timedelta(seconds=1199999.5)
<= operation.response.expire_time
<= operation.response.create_time + datetime.timedelta(seconds=120.5)
<= operation.response.create_time + datetime.timedelta(seconds=1200000.5)
)
finally:
# Clean up resources.
Expand All @@ -60,7 +61,7 @@ def test_create_session_with_expire_time(client):
assert isinstance(agent_engine, types.AgentEngine)
assert isinstance(agent_engine.api_resource, types.ReasoningEngine)
expire_time = datetime.datetime(
2026, 1, 1, 12, 30, 00, tzinfo=datetime.timezone.utc
2028, 1, 1, 12, 30, 00, tzinfo=datetime.timezone.utc
)

operation = client.agent_engines.sessions.create(
Expand All @@ -78,6 +79,7 @@ def test_create_session_with_expire_time(client):
assert operation.response.user_id == "test-user-123"
assert operation.response.name.startswith(agent_engine.api_resource.name)
assert operation.response.expire_time == expire_time
assert operation.done
finally:
# Clean up resources.
client.agent_engines.delete(name=agent_engine.api_resource.name, force=True)
Expand Down
30 changes: 18 additions & 12 deletions vertexai/_genai/sessions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,12 +651,15 @@ def create(
user_id=user_id,
config=config,
)
if config.wait_for_completion and not operation.done:
operation = _agent_engines_utils._await_operation(
operation_name=operation.name,
get_operation_fn=self._get_session_operation,
poll_interval_seconds=0.5,
)
if config.wait_for_completion:
if not operation.done:
operation = _agent_engines_utils._await_operation(
operation_name=operation.name,
get_operation_fn=self._get_session_operation,
poll_interval_seconds=0.5,
)
# We need to make a call to get the session because the operation
# response might not contain the relevant fields.
if operation.response:
operation.response = self.get(name=operation.response.name)
elif operation.error:
Expand Down Expand Up @@ -1133,12 +1136,15 @@ async def create(
user_id=user_id,
config=config,
)
if config.wait_for_completion and not operation.done:
operation = await _agent_engines_utils._await_async_operation(
operation_name=operation.name,
get_operation_fn=self._get_session_operation,
poll_interval_seconds=0.5,
)
if config.wait_for_completion:
if not operation.done:
operation = await _agent_engines_utils._await_async_operation(
operation_name=operation.name,
get_operation_fn=self._get_session_operation,
poll_interval_seconds=0.5,
)
# We need to make a call to get the session because the operation
# response might not contain the relevant fields.
if operation.response:
operation.response = await self.get(name=operation.response.name)
elif operation.error:
Expand Down
Loading