Skip to content

Comments

Update timestamp output format system test to use direct request#651

Draft
danieljbruce wants to merge 1 commit intowrite-api-changes-2from
update-timestamp-test-to-use-request-3432412269925724150
Draft

Update timestamp output format system test to use direct request#651
danieljbruce wants to merge 1 commit intowrite-api-changes-2from
update-timestamp-test-to-use-request-3432412269925724150

Conversation

@danieljbruce
Copy link
Contributor

The system test for timestamp output format was modified to use a direct API request via the ServiceObject.request method inherited by the Table class. This change avoids dependency on unreleased library features in @google-cloud/bigquery and allows for direct verification of high-precision timestamp strings as returned by the BigQuery API.

Key changes:

  • Replaced table.getRows(options) with (table as any).request({ uri: '/data', qs: options }, callback).
  • Updated assertions to validate the raw API response structure (resp.rows[0].f[0].v).
  • Wrapped the callback-based request in a Promise to maintain compatibility with the existing async/await test structure.
  • Handled both success and error cases as defined in the test suite.

PR created automatically by Jules for task 3432412269925724150 started by @danieljbruce

Modify the system test in `timestamp_output_format.ts` to use `table.request`
instead of `table.getRows`. This ensures that we are checking the raw
data returned by the server, bypassing any unreleased changes in the
BigQuery library. The test now verifies high-precision timestamps by
inspecting the raw JSON response from the `/data` endpoint.

Co-authored-by: danieljbruce <8935272+danieljbruce@users.noreply.github.com>
@google-labs-jules
Copy link

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. labels Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquerystorage Issues related to the googleapis/nodejs-bigquery-storage API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant