build: Remove @InternalApi from GAPIC Admin Base clients#2834
Open
jinseopkim0 wants to merge 4 commits intomainfrom
Open
build: Remove @InternalApi from GAPIC Admin Base clients#2834jinseopkim0 wants to merge 4 commits intomainfrom
jinseopkim0 wants to merge 4 commits intomainfrom
Conversation
Updates owlbot.py to stop injecting `@InternalApi` into `BaseBigtableTableAdminClient`, `BaseBigtableInstanceAdminClient`, and their respective Settings classes. Since we recently exposed these Base classes to users via `getBaseClient()` as part of the GAPIC modernization effort, they are now part of the public API surface and should no longer be marked as internal. Stubs remain marked as internal. Tracking Bug: b/475818901
product-auto-label
bot
added
size: xs
product-auto-label
bot
added
size: xl
|
Warning: This pull request is touching the following templated files:
|
jinseopkim0
added a commit
that referenced
this pull request
Mar 6, 2026
In PR #2834, we removed the @internalapi annotations from the Admin API stub classes to align with a vanilla GAPIC surface. Because they are no longer internal, we must expose them in the public Javadoc reference documentation so that power users can use them for advanced configuration and custom transports. This commit updates the `pom.xml` file to: - Remove `sourceFileExclude` entries for Admin API stub classes in the `maven-javadoc-plugin` configuration. - Update the `docFX` regex to stop excluding `stub.*` classes for the `admin.v2` package.
lqiu96
reviewed
Mar 6, 2026
Comment on lines
+85
to
+89
| /** | ||
| * Base stub class for the BigtableInstanceAdmin service API. | ||
| * | ||
| * <p>This class is for advanced usage and reflects the underlying API directly. | ||
| */ |
Member
There was a problem hiding this comment.
just to confirm: This is the generated comment from the generator right? Otherwise this custom comment would be overwritten on the next generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates owlbot.py to stop injecting
@InternalApiintoBaseBigtableTableAdminClient,BaseBigtableInstanceAdminClient, and their respective Settings classes.Since we recently exposed these Base classes to users via
getBaseClient()as part of the GAPIC modernization effort, they are now part of the public API surface and should no longer be marked as internal.Tracking Bug: b/475818901