Skip to content

impl(gaxi): add unimplemented stub helper for bidi - #6319

Merged
suzmue merged 1 commit into
googleapis:mainfrom
suzmue:bidi-unimplemented-stub
Aug 10, 2026
Merged

impl(gaxi): add unimplemented stub helper for bidi#6319
suzmue merged 1 commit into
googleapis:mainfrom
suzmue:bidi-unimplemented-stub

Conversation

@suzmue

@suzmue suzmue commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

We will use this in the generated code for the unimplemented stub to replace the workaround that uses the existing unimplemented_stub.

@suzmue
suzmue requested a review from a team as a code owner August 10, 2026 18:00

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for an unimplemented bidirectional streaming stub (unimplemented_bidi_stub) in src/gax-internal/src/unimplemented.rs, conditionally compiled under the google_cloud_unstable_gapic_streaming feature flag. It also introduces corresponding unit tests to verify that both the standard and bidirectional unimplemented stubs panic as expected. I have no feedback to provide on these changes.

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.27%. Comparing base (2a3e1e0) to head (446b5a1).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6319   +/-   ##
=======================================
  Coverage   96.26%   96.27%           
=======================================
  Files         283      283           
  Lines       73110    73119    +9     
=======================================
+ Hits        70380    70393   +13     
+ Misses       2730     2726    -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suzmue
suzmue enabled auto-merge (squash) August 10, 2026 18:16
@suzmue
suzmue merged commit b584f03 into googleapis:main Aug 10, 2026
41 checks passed
@suzmue
suzmue deleted the bidi-unimplemented-stub branch August 10, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants