impl(gaxi): add unimplemented stub helper for bidi - #6319
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for an unimplemented bidirectional streaming stub (unimplemented_bidi_stub) in src/gax-internal/src/unimplemented.rs, conditionally compiled under the google_cloud_unstable_gapic_streaming feature flag. It also introduces corresponding unit tests to verify that both the standard and bidirectional unimplemented stubs panic as expected. I have no feedback to provide on these changes.
coryan
approved these changes
Aug 10, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6319 +/- ##
=======================================
Coverage 96.26% 96.27%
=======================================
Files 283 283
Lines 73110 73119 +9
=======================================
+ Hits 70380 70393 +13
+ Misses 2730 2726 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will use this in the generated code for the unimplemented stub to replace the workaround that uses the existing unimplemented_stub.