feat(o11y): remove google_cloud_unstable_tracing gate for LRO tracing#5897
Draft
haphungw wants to merge 8 commits into
Draft
feat(o11y): remove google_cloud_unstable_tracing gate for LRO tracing#5897haphungw wants to merge 8 commits into
google_cloud_unstable_tracing gate for LRO tracing#5897haphungw wants to merge 8 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request stabilizes tracing and poller options across various generated Google Cloud clients by removing the google_cloud_unstable_tracing conditional compilation flags. It also exposes internal observability error types and helper functions by increasing their visibility to public. Regarding the feedback, a naming convention issue was identified in observability/errors.rs where a method returning an owned String was prefixed with as_ instead of to_.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5897 +/- ##
==========================================
- Coverage 97.89% 97.85% -0.04%
==========================================
Files 233 235 +2
Lines 59202 59812 +610
==========================================
+ Hits 57958 58532 +574
- Misses 1244 1280 +36 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
haphungw
force-pushed
the
remove-lro-tracing-gate
branch
from
4c1daf8 to
2e403c8
Compare
Add error.type attribute to the LRO Wait span and populate it from the status code if the long-running operation fails with a status code. This allows observability tools to track error rates by error type for long-running operations.
haphungw
force-pushed
the
remove-lro-tracing-gate
branch
from
2e403c8 to
5872328
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.