test(o11y): add Discovery LRO tracing success integration test#5891
test(o11y): add Discovery LRO tracing success integration test#5891haphungw wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces integration tests for Long-Running Operation (LRO) tracing within the o11y integration tests, covering successful polling, logical errors, transient and permanent RPC errors, and discovery-based LRO success. The review feedback suggests removing a redundant #[cfg(google_cloud_unstable_tracing)] attribute within tests/o11y/src/lro_tracing.rs since the entire file is already gated by this configuration at the module level.
| #[cfg(google_cloud_unstable_tracing)] | ||
| google_cloud_lro::record_polling_attributes!(&span); |
There was a problem hiding this comment.
The #[cfg(google_cloud_unstable_tracing)] attribute is redundant here because the entire file is already gated by #![cfg(google_cloud_unstable_tracing)] at the module level (line 15). Removing it simplifies the code and improves readability.
| #[cfg(google_cloud_unstable_tracing)] | |
| google_cloud_lro::record_polling_attributes!(&span); | |
| google_cloud_lro::record_polling_attributes!(&span); |
d034683 to
def8d91
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5891 +/- ##
=======================================
Coverage 97.89% 97.89%
=======================================
Files 233 233
Lines 59202 59202
=======================================
Hits 57958 57958
Misses 1244 1244 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
def8d91 to
43a89a6
Compare
Add error.type attribute to the LRO Wait span and populate it from the status code if the long-running operation fails with a status code. This allows observability tools to track error rates by error type for long-running operations.
43a89a6 to
5fa7173
Compare
5fa7173 to
4e56084
Compare
Introduce tracing tests for success cases for Discovery-based client pollers.
Stacked on top of https://github.com/googleapis/google-cloud-rust/pull/5889.