fix(bigframes): Drop support for Python <= 3.9#16961
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes support for Python 3.9 and older versions across the repository. Key changes include updating the contributing documentation, removing Python 3.9 from the Nox configuration, and deleting redundant version-based test skips in the unit and system test suites. Feedback was provided to ensure that the project's metadata in configuration files like setup.py or pyproject.toml is also updated to reflect the new minimum Python version requirement.
I am having trouble creating individual review comments. Click here to see my feedback.
packages/bigframes/noxfile.py (63)
When updating the minimum supported Python version, ensure that the project's metadata in setup.py or pyproject.toml is also updated to reflect the same minimum version in python_requires and Trove classifiers.
References
- When updating the minimum supported Python version in runtime checks (e.g., 'sys.version_info' checks), ensure that the project's metadata in 'setup.py' or 'pyproject.toml' is also updated to reflect the same minimum version in 'python_requires' and Trove classifiers.
tswast
left a comment
There was a problem hiding this comment.
Thanks for the cleanup. Looks like it's already dropped here: https://github.com/googleapis/google-cloud-python/blob/main/packages/bigframes/setup.py#L160 so this is more of a chore than a fix.
Note
This is part of a larger effort across the monorepo to ensure that all packages are focused on currently supported Python runtimes. This package was already heavily focused on 3.10 support so changes should be fairly minimal.
This PR updates
bigframesto establish Python 3.10 as the minimum supported version, dropping support for Python 3.9 and below.Changes
noxfile.pyto remove references to Python 3.9 from the supported versions list.CONTRIBUTING.rstto use Python 3.10 in sample commands and removed stale Python 2 compatibility notes.noxfile.pythat was skipping Python 3.7, 3.8, and 3.9.Removed dead code in
tests/unit/test_pandas.pychecking for Python < 3.10.Fixes internal issue: http://b/482126936 🦕