Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 0 additions & 1 deletion .generator/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ RUN unzip protoc-25.3-linux-x86_64.zip -d protoc

# Download/extract pandoc
# Pandoc is required by gapic-generator-python for parsing documentation
# version-scanner: ignore-next-line
ENV PANDOC_VERSION=3.8.2
RUN mkdir pandoc-binary
RUN wget https://github.com/jgm/pandoc/releases/download/${PANDOC_VERSION}/pandoc-${PANDOC_VERSION}-linux-amd64.tar.gz
Expand Down
2 changes: 1 addition & 1 deletion .generator/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ def _run_post_processor(output: str, library_id: str, is_mono_repo: bool):
# TODO(https://github.com/googleapis/google-cloud-python/issues/15538):
# Investigate if a `target_version needs to be maintained
# or can be eliminated.
target_version = "py310"
target_version = "py39"
common_args = [
f"--target-version={target_version}",
"--line-length=88",
Expand Down
2 changes: 1 addition & 1 deletion .generator/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,7 @@ def test_run_individual_session_success(mocker, caplog, is_mono_repo):
"cli.subprocess.run", return_value=MagicMock(returncode=0)
)

test_session = "unit-3.10"
test_session = "unit-3.9"
test_library_id = "test-library"
repo = "repo"
_run_individual_session(test_session, test_library_id, repo, is_mono_repo)
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/bigtable-conformance.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
outputs:
run_bigtable: ${{ steps.filter.outputs.bigtable }}
steps:
- uses: actions/checkout@v6
- uses: dorny/paths-filter@v4
- uses: actions/checkout@v4
- uses: dorny/paths-filter@v3
id: filter
with:
filters: |
Expand All @@ -48,18 +48,18 @@ jobs:
fail-fast: false
name: "${{ matrix.client-type }} client / python ${{ matrix.py-version }} / test tag ${{ matrix.test-version }}"
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@v4
name: "Checkout google-cloud-python"
- uses: actions/checkout@v6
- uses: actions/checkout@v4
name: "Checkout conformance tests"
with:
repository: googleapis/cloud-bigtable-clients-test
ref: ${{ matrix.test-version }}
path: packages/google-cloud-bigtable/cloud-bigtable-clients-test
- uses: actions/setup-python@v6
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.py-version }}
- uses: actions/setup-go@v6
- uses: actions/setup-go@v5
with:
go-version: '>=1.20.2'
- run: pip install -e .
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/django-spanner-foreign_keys.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
outputs:
run_django_spanner: ${{ steps.filter.outputs.django_spanner }}
steps:
- uses: actions/checkout@v6
- uses: dorny/paths-filter@v4
- uses: actions/checkout@v4
- uses: dorny/paths-filter@v3
id: filter
with:
filters: |
Expand All @@ -43,9 +43,9 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v6
uses: actions/checkout@v4
- name: Setup Python
uses: actions/setup-python@v6
uses: actions/setup-python@v5
with:
python-version: "3.10"
- name: Run Django foreign key test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
outputs:
run_django_spanner: ${{ steps.filter.outputs.django_spanner }}
steps:
- uses: actions/checkout@v6
- uses: dorny/paths-filter@v4
- uses: actions/checkout@v4
- uses: dorny/paths-filter@v3
id: filter
with:
filters: |
Expand All @@ -44,9 +44,9 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v6
- name: Set up Python 3.10
uses: actions/setup-python@v6
uses: actions/checkout@v4
- name: Set up Python 3.20
uses: actions/setup-python@v5
with:
python-version: "3.10"
- name: Install nox
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/django-spanner-mockserver-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
outputs:
run_django_spanner: ${{ steps.filter.outputs.django_spanner }}
steps:
- uses: actions/checkout@v6
- uses: dorny/paths-filter@v4
- uses: actions/checkout@v4
- uses: dorny/paths-filter@v3
id: filter
with:
filters: |
Expand All @@ -37,9 +37,9 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v6
uses: actions/checkout@v4
- name: Set up Python 3.12
uses: actions/setup-python@v6
uses: actions/setup-python@v5
with:
python-version: "3.12"
- name: Install nox
Expand Down
31 changes: 10 additions & 21 deletions .github/workflows/gapic-generator-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ env:
SHOWCASE_VERSION: 0.35.0
PROTOC_VERSION: 3.20.2
LATEST_STABLE_PYTHON: 3.14
ALL_PYTHON: "['3.10', '3.11', '3.12', '3.13', '3.14']"
ALL_PYTHON: "['3.9', '3.10', '3.11', '3.12', '3.13', '3.14']"

jobs:
check_changes:
Expand All @@ -30,8 +30,8 @@ jobs:
outputs:
run_generator: ${{ steps.filter.outputs.generator }}
steps:
- uses: actions/checkout@v6
- uses: dorny/paths-filter@v4
- uses: actions/checkout@v4
- uses: dorny/paths-filter@v3
id: filter
with:
filters: |
Expand Down Expand Up @@ -60,7 +60,7 @@ jobs:
logging_scope: ["", "google"]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@v5
- name: Set up Python
uses: actions/setup-python@v6
with:
Expand All @@ -84,7 +84,7 @@ jobs:
needs: python_config
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@v5
- name: Set up Python
uses: actions/setup-python@v6
with:
Expand All @@ -101,7 +101,7 @@ jobs:
needs: python_config
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@v5
- name: Set up Python
uses: actions/setup-python@v6
with:
Expand All @@ -115,23 +115,12 @@ jobs:
for pkg in credentials eventarc logging redis; do
nox -f tests/integration/goldens/$pkg/noxfile.py -s format lint unit-${{ needs.python_config.outputs.latest_stable_python }}
done
# Run pylint (errors-only) over the goldens so generator regressions
# like undefined names or import-time breakage that ruff/flake8 do
# not flag are caught at PR time.
# See https://github.com/googleapis/google-cloud-python/issues/16393.
- name: Pylint goldens (errors only)
run: |
pip install --quiet pylint
cd packages/gapic-generator/tests/integration/goldens
for pkg in credentials eventarc logging redis; do
pylint --rcfile=.pylintrc --errors-only --recursive=y "$pkg/google"
done

goldens-prerelease:
needs: python_config
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@v5
- name: Set up Python
uses: actions/setup-python@v6
with:
Expand All @@ -153,7 +142,7 @@ jobs:
python: ["3.10", "3.14"]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@v5
- name: Set up Python
uses: actions/setup-python@v6
with:
Expand Down Expand Up @@ -183,11 +172,11 @@ jobs:
runs-on: ubuntu-latest
container: gcr.io/gapic-images/googleapis
steps:
- uses: actions/checkout@v6
- uses: actions/checkout@v5

- name: Cache Bazel files
id: cache-bazel
uses: actions/cache@v5
uses: actions/cache@v4
with:
path: ~/.cache/bazel
# Ensure CACHE_VERSION is defined in the mono-repo secrets!
Expand Down
5 changes: 0 additions & 5 deletions .kokoro/continuous/continuous-bigframes.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,3 @@ env_vars: {
key: "NOX_SESSION"
value: "e2e load system_prerelease notebook system_noextras"
}

env_vars: {
key: "BIGFRAMES_TEST_PROJECT"
value: "bigframes-load-testing"
}
5 changes: 0 additions & 5 deletions .kokoro/continuous/prerelease.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,3 @@ env_vars: {
key: "NOX_SESSION"
value: "prerelease_deps"
}

env_vars: {
key: "BIGFRAMES_TEST_PROJECT"
value: "bigframes-load-testing"
}
5 changes: 0 additions & 5 deletions .kokoro/continuous/system.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,3 @@ env_vars: {
key: "NOX_SESSION"
value: "system-3.12"
}

env_vars: {
key: "BIGFRAMES_TEST_PROJECT"
value: "bigframes-load-testing"
}
5 changes: 0 additions & 5 deletions .kokoro/presubmit/prerelease.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,3 @@ env_vars: {
key: "NOX_SESSION"
value: "prerelease_deps"
}

env_vars: {
key: "BIGFRAMES_TEST_PROJECT"
value: "bigframes-testing"
}
7 changes: 1 addition & 6 deletions .kokoro/presubmit/presubmit-doctest-bigframes.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,4 @@ env_vars: {
env_vars: {
key: "TRAMPOLINE_BUILD_FILE"
value: "github/google-cloud-python/packages/bigframes/scripts/run_doctest.sh"
}

env_vars: {
key: "BIGFRAMES_TEST_PROJECT"
value: "bigframes-testing"
}
}
5 changes: 0 additions & 5 deletions .kokoro/presubmit/system.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,3 @@ env_vars: {
key: "NOX_SESSION"
value: "system-3.12"
}

env_vars: {
key: "BIGFRAMES_TEST_PROJECT"
value: "bigframes-testing"
}
18 changes: 4 additions & 14 deletions .kokoro/system.sh
Original file line number Diff line number Diff line change
Expand Up @@ -133,24 +133,14 @@ for path in `find 'packages' \
package_path="packages/${package_name}"

# Determine if we should skip based on git diff
# We always check for changes in these specific versioning/config files
files_to_check=(
"${package_path}/CHANGELOG.md"
"${package_path}/setup.py"
"${package_path}/pyproject.toml"
"${package_path}/**/gapic_version.py"
"${package_path}/**/version.py"
)

# If the package is in our "always run full system tests" list, check the whole directory
files_to_check="${package_path}/CHANGELOG.md"
if [[ $package_name == @($packages_with_system_tests_pattern) ]]; then
files_to_check=("${package_path}")
files_to_check="${package_path}"
fi

echo "checking changes with 'git diff ${KOKORO_GITHUB_PULL_REQUEST_TARGET_BRANCH}...${KOKORO_GITHUB_PULL_REQUEST_COMMIT} -- ${files_to_check[*]}'"
echo "checking changes with 'git diff "${KOKORO_GITHUB_PULL_REQUEST_TARGET_BRANCH}...${KOKORO_GITHUB_PULL_REQUEST_COMMIT}" -- ${files_to_check}'"
set +e
# Passing the array expanded as arguments to git diff
package_modified=$(git diff "${KOKORO_GITHUB_PULL_REQUEST_TARGET_BRANCH}...${KOKORO_GITHUB_PULL_REQUEST_COMMIT}" -- "${files_to_check[@]}" | wc -l)
package_modified=$(git diff "${KOKORO_GITHUB_PULL_REQUEST_TARGET_BRANCH}...${KOKORO_GITHUB_PULL_REQUEST_COMMIT}" -- ${files_to_check} | wc -l)
set -e

if [[ "${package_modified}" -gt 0 || "$KOKORO_BUILD_ARTIFACTS_SUBDIR" == *"continuous"* ]]; then
Expand Down
14 changes: 9 additions & 5 deletions .librarian/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ global_files_allowlist:
libraries:
# libraries have "release_blocked: true" so that releases are
# explicitly initiated.
# TODO(https://github.com/googleapis/google-cloud-python/issues/16180):
# `google-django-spanner` is blocked until the presubmits are green.
- id: "google-django-spanner"
release_blocked: true
# TODO(https://github.com/googleapis/google-cloud-python/issues/16487):
# Allow releases for google-cloud-storage once this bug is fixed.
- id: "google-cloud-storage"
Expand All @@ -27,10 +31,10 @@ libraries:
# Allow release for google-crc32c once this bug is fixed.
- id: "google-crc32c"
release_blocked: true
# TODO(b/501132869): Disabling automatic releases until resolved.
- id: "google-cloud-bigtable"
release_blocked: true
# TODO(https://github.com/googleapis/google-cloud-python/issues/16780): Disabling automatic releases until resolved.
# TODO(https://github.com/googleapis/google-cloud-python/issues/16780):
# Allow release for google-cloud-compute (and beta) after we've checked that
# the gRPC service config is okay.
- id: "google-cloud-compute"
release_blocked: true

- id: "google-cloud-compute-v1beta"
release_blocked: true
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,6 @@ url: https://github.com/googleapis/gapic-generator-python/issues/2490
# is annoying, but that's what synthtool expects and it's not worth fixing that
# at this stage.
replacements:
- paths: [
packages/google-analytics-data/noxfile.py,
]
before: ' "-W", # warnings as errors\n'
after: ''
count: 1
- paths: [
packages/google-cloud-compute/noxfile.py,
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ replacements:
before: |
.. include:: README.rst\n
.. include:: multiprocessing.rst\n
This package includes clients for multiple versions of BigQuery Storage.
This package includes clients for multiple versions of Google BigQuery Storage.
By default, you will get version ``bigquery_storage_v1``.\n\n
API Reference
-------------
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ replacements:
- paths: [
packages/google-cloud-bigtable/google/cloud/bigtable_admin_v2/__init__.py
]
before: '"UpdateTableRequest",\n\)\n\Z'
before: '"UpdateTableRequest",\n\)\n\z'
after: |
"UpdateTableRequest",
)
Expand All @@ -259,7 +259,7 @@ replacements:
- paths: [
packages/google-cloud-bigtable/google/cloud/bigtable_admin/__init__.py
]
before: '"Type",\n\)\n\Z'
before: '"Type",\n\)\n\z'
after: |
"Type",
)
Expand Down Expand Up @@ -325,7 +325,7 @@ replacements:
packages/google-cloud-bigtable/README.rst
]
before: |
.. _Product Documentation: https://cloud.google.com/bigtable/docs\n
.. _Product Documentation: https://cloud.google.com/bigtable\n
Quick Start
after: |
.. _Product Documentation: https://cloud.google.com/bigtable/docs
Expand Down
Loading
Loading