chore: librarian update image pull request: 20260310T162647Z#16063
Draft
chore: librarian update image pull request: 20260310T162647Z#16063
Conversation
…prod/images-prod/python-librarian-generator@sha256:701bd1403bebb772cbc1835dc7a88aea5a07638222363534f0282bb1275b93c6
Contributor
Author
|
One or more libraries have failed to generate, please review PR description for a list of failed libraries. |
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on maintaining the project's infrastructure and client library consistency. It updates the core librarian image, refines Python version compatibility, and modernizes dependency management. Significant changes were also made to client and transport classes across various services, enhancing API endpoint handling and operation request processing. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request appears to be an automated update from the librarian tool, refreshing the generator image and regenerating client code. The changes include dropping support for Python 3.7 and 3.8, updating dependencies, adding type hints, and fixing a potential AttributeError in _get_default_mtls_endpoint. Overall, these are positive improvements. However, I've identified a couple of inconsistencies in the constraints-3.9.txt files where dependency versions are not pinned to the correct lower bounds as specified in the corresponding setup.py files. I've left specific comments with suggestions to correct these.
Note: Security Review did not run due to the size of the PR.
Comment on lines
+8
to
+9
| google-api-core==2.21.0 | ||
| google-auth==2.35.0 |
Contributor
There was a problem hiding this comment.
The versions for google-api-core and google-auth in this constraints file do not appear to match the lower bounds specified in setup.py. According to the comment in this file, these should be pinned to their lower bounds.
google-api-coreshould be2.11.0(fromsetup.py:google-api-core[grpc] >= 2.11.0, <3.0.0).google-authshould be2.14.1(fromsetup.py:google-auth >= 2.14.1, <3.0.0,...).
Please update these to reflect the correct lower bounds.
google-api-core==2.11.0
google-auth==2.14.1
Comment on lines
+8
to
+9
| google-api-core==2.21.0 | ||
| google-auth==2.35.0 |
Contributor
There was a problem hiding this comment.
The versions for google-api-core and google-auth in this constraints file do not appear to match the lower bounds specified in setup.py. According to the comment in this file, these should be pinned to their lower bounds.
google-api-coreshould be2.11.0(fromsetup.py:google-api-core[grpc] >= 2.11.0, <3.0.0).google-authshould be2.14.1(fromsetup.py:google-auth >= 2.14.1, <3.0.0,...).
Please update these to reflect the correct lower bounds.
google-api-core==2.11.0
google-auth==2.14.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:701bd1403bebb772cbc1835dc7a88aea5a07638222363534f0282bb1275b93c6
Generation failed for