-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat(firestore): literals pipeline stage #16028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -275,6 +275,71 @@ def find_nearest( | |||||||||||||||||
| stages.FindNearest(field, vector, distance_measure, options) | ||||||||||||||||||
| ) | ||||||||||||||||||
|
|
||||||||||||||||||
| def literals(self, *documents: Selectable | dict) -> "_BasePipeline": | ||||||||||||||||||
| """ | ||||||||||||||||||
| Returns documents from a fixed set of predefined document objects. | ||||||||||||||||||
|
|
||||||||||||||||||
| This stage is commonly used for testing other stages in isolation, | ||||||||||||||||||
| though it can also be used as inputs to join conditions. | ||||||||||||||||||
|
|
||||||||||||||||||
| Example: | ||||||||||||||||||
| >>> from google.cloud.firestore_v1.pipeline_expressions import Constant | ||||||||||||||||||
| >>> documents = [ | ||||||||||||||||||
| ... {"name": "joe", "age": 10}, | ||||||||||||||||||
| ... {"name": "bob", "age": 30}, | ||||||||||||||||||
| ... {"name": "alice", "age": 40} | ||||||||||||||||||
| ... ] | ||||||||||||||||||
| >>> pipeline = client.pipeline() | ||||||||||||||||||
| ... .literals(Constant.of(documents)) | ||||||||||||||||||
| ... .where(field("age").lessThan(35)) | ||||||||||||||||||
|
|
||||||||||||||||||
| Output documents: | ||||||||||||||||||
| ```json | ||||||||||||||||||
| [ | ||||||||||||||||||
| {"name": "joe", "age": 10}, | ||||||||||||||||||
| {"name": "bob", "age": 30} | ||||||||||||||||||
| ] | ||||||||||||||||||
| ``` | ||||||||||||||||||
|
|
||||||||||||||||||
| Behavior: | ||||||||||||||||||
| The `literals(...)` stage can only be used as the first stage in a pipeline (or | ||||||||||||||||||
| sub-pipeline). The order of documents returned from the `literals` matches the | ||||||||||||||||||
| order in which they are defined. | ||||||||||||||||||
|
|
||||||||||||||||||
| While literal values are the most common, it is also possible to pass in | ||||||||||||||||||
| expressions, which will be evaluated and returned, making it possible to test | ||||||||||||||||||
| out different query / expression behavior without first needing to create some | ||||||||||||||||||
| test data. | ||||||||||||||||||
|
|
||||||||||||||||||
| For example, the following shows how to quickly test out the `length(...)` | ||||||||||||||||||
| function on some constant test sets: | ||||||||||||||||||
|
|
||||||||||||||||||
| Example: | ||||||||||||||||||
| >>> from google.cloud.firestore_v1.pipeline_expressions import Constant | ||||||||||||||||||
| >>> documents = [ | ||||||||||||||||||
| ... {"x": Constant.of("foo-bar-baz").char_length()}, | ||||||||||||||||||
| ... {"x": Constant.of("bar").char_length()} | ||||||||||||||||||
| ... ] | ||||||||||||||||||
| >>> pipeline = client.pipeline().literals(Constant.of(documents)) | ||||||||||||||||||
|
|
||||||||||||||||||
| Output documents: | ||||||||||||||||||
| ```json | ||||||||||||||||||
| [ | ||||||||||||||||||
| {"x": 11}, | ||||||||||||||||||
| {"x": 3} | ||||||||||||||||||
| ] | ||||||||||||||||||
| ``` | ||||||||||||||||||
|
|
||||||||||||||||||
| Args: | ||||||||||||||||||
| documents: A `str` or `Selectable` expression. If a `str`, it's | ||||||||||||||||||
| treated as a field path to an array of documents. | ||||||||||||||||||
| If a `Selectable`, it's usually a `Constant` | ||||||||||||||||||
| containing an array of documents (as dictionaries). | ||||||||||||||||||
|
Comment on lines
+334
to
+337
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The
Suggested change
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. +1. Usually I'd put the * in here too: |
||||||||||||||||||
| Returns: | ||||||||||||||||||
| A new Pipeline object with this stage appended to the stage list. | ||||||||||||||||||
| """ | ||||||||||||||||||
| return self._append(stages.Literals(*documents)) | ||||||||||||||||||
|
|
||||||||||||||||||
| def replace_with( | ||||||||||||||||||
| self, | ||||||||||||||||||
| field: Selectable, | ||||||||||||||||||
|
|
||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -684,4 +684,23 @@ tests: | |
| - args: | ||
| - fieldReferenceValue: awards | ||
| - stringValue: full_replace | ||
| name: replace_with | ||
| name: replace_with | ||
| - description: literals | ||
| pipeline: | ||
| - Literals: | ||
| - title: "The Hitchhiker's Guide to the Galaxy" | ||
| author: "Douglas Adams" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe it's been a while since I looked at this, but this doesn't seem like the right syntax to me. Isn't this essentially sending Does the test pass? |
||
| assert_results: | ||
| - title: "The Hitchhiker's Guide to the Galaxy" | ||
| author: "Douglas Adams" | ||
| assert_proto: | ||
| pipeline: | ||
| stages: | ||
| - args: | ||
| - mapValue: | ||
| fields: | ||
| author: | ||
| stringValue: "Douglas Adams" | ||
| title: | ||
| stringValue: "The Hitchhiker's Guide to the Galaxy" | ||
| name: literals | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should also have tests here that cover the different input types we support |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -517,6 +517,35 @@ def test_to_pb(self): | |
| assert len(result.options) == 0 | ||
|
|
||
|
|
||
| class TestLiterals: | ||
| def _make_one(self, *args, **kwargs): | ||
| return stages.Literals(*args, **kwargs) | ||
|
|
||
| def test_ctor(self): | ||
| val1 = Constant.of({"a": 1}) | ||
| val2 = {"b": 2} | ||
| instance = self._make_one(val1, val2) | ||
| assert instance.documents == (val1, val2) | ||
| assert instance.name == "literals" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should have tests that cover all supported input types. I don't see anything using str (and looking at go, I'm not sure if we should be supporting str?) |
||
|
|
||
| def test_repr(self): | ||
| val1 = Constant.of({"a": 1}) | ||
| instance = self._make_one(val1, {"b": 2}) | ||
| repr_str = repr(instance) | ||
| assert repr_str == "Literals(documents=(Constant.of({'a': 1}), {'b': 2}))" | ||
|
|
||
| def test_to_pb(self): | ||
| val1 = Constant.of({"a": 1}) | ||
| val2 = {"b": 2} | ||
| instance = self._make_one(val1, val2) | ||
| result = instance._to_pb() | ||
| assert result.name == "literals" | ||
| assert len(result.args) == 2 | ||
| assert result.args[0].map_value.fields["a"].integer_value == 1 | ||
| assert result.args[1].map_value.fields["b"].integer_value == 2 | ||
| assert len(result.options) == 0 | ||
|
|
||
|
|
||
| class TestOffset: | ||
| def _make_one(self, *args, **kwargs): | ||
| return stages.Offset(*args, **kwargs) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the code, it seems like: