feat(google/logging/v2): onboard a new library#8863
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the new @google-cloud/logging-api package, which contains auto-generated clients, samples, and proto definitions for the Cloud Logging API (including Config, Logging, and Metrics services). The review feedback highlights two issues: first, the auto-generated links in the README point to the wrong package directory and should be corrected upstream in the generator templates; second, the webpack configuration should be updated to use a more generic library name and filename, as the package exports multiple services rather than just ConfigServiceV2.
| [homepage_samples]: https://github.com/googleapis/google-cloud-node/blob/main/packages/google-logging/samples | ||
| [homepage_changelog]: https://github.com/googleapis/google-cloud-node/blob/main/packages/google-logging/CHANGELOG.md | ||
| [homepage]: https://github.com/googleapis/google-cloud-node/blob/main/packages/google-logging |
There was a problem hiding this comment.
The auto-generated links at the bottom of the README point to packages/google-logging instead of this package's directory (packages/google-cloud-logging-api). Since this file is auto-generated, please update the generator templates or configuration upstream to ensure the correct package directory is used for these links.
References
- Do not manually edit auto-generated files to fix typos or make other changes, as these edits will be overwritten during the next regeneration. Instead, apply the fixes upstream in the generator or templates.
| output: { | ||
| library: 'ConfigServiceV2', | ||
| filename: './config-service-v2.js', | ||
| }, |
There was a problem hiding this comment.
The webpack configuration appears to have been copied from a single-service package and still uses ConfigServiceV2 as the library name and ./config-service-v2.js as the filename. Since this package exports multiple services (ConfigServiceV2, LoggingServiceV2, and MetricsServiceV2), the library name and filename should be updated to be more generic and representative of the entire package (e.g., LoggingApi and ./logging-api.js).
| output: { | |
| library: 'ConfigServiceV2', | |
| filename: './config-service-v2.js', | |
| }, | |
| output: { | |
| library: 'LoggingApi', | |
| filename: './logging-api.js', | |
| }, |
1 participant
No description provided.