feat(google/cloud/bigquery/v2): onboard a new library#8862
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds the google-cloud-bigquery-api package, including the necessary configuration files, documentation, and proto definitions. The reviewer identified a version mismatch between librarian.yaml and package.json and suggested using metadata_name_override and name_pretty_override in librarian.yaml to properly handle naming conflicts with the existing bigquery library instead of manually editing the generated metadata file.
| nodejs: | ||
| default_version: v1 | ||
| - name: google-cloud-bigquery-api | ||
| version: 1.0.0 |
| nodejs: | ||
| package_name: '@google-cloud/bigquery-api' |
There was a problem hiding this comment.
To avoid naming conflicts with the existing @google-cloud/bigquery library (which already uses the name bigquery and pretty name BigQuery), please configure metadata_name_override and name_pretty_override in librarian.yaml under the nodejs section instead of manually editing the generated .repo-metadata.json file.
nodejs:
package_name: '@google-cloud/bigquery-api'
metadata_name_override: bigquery-api
name_pretty_override: BigQuery APIReferences
- To override the metadata name and pretty name for a library to avoid naming conflicts, configure
metadata_name_overrideandname_pretty_overrideinlibrarian.yamlinstead of manually editing the generated.repo-metadata.jsonfile.
No description provided.