Skip to content

feat(google/cloud/bigquery/v2): onboard a new library#8862

Draft
quirogas wants to merge 1 commit into
googleapis:mainfrom
quirogas:feat/onboard-bigquery-api
Draft

feat(google/cloud/bigquery/v2): onboard a new library#8862
quirogas wants to merge 1 commit into
googleapis:mainfrom
quirogas:feat/onboard-bigquery-api

Conversation

@quirogas

Copy link
Copy Markdown
Contributor

No description provided.

@quirogas quirogas self-assigned this Jul 10, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the google-cloud-bigquery-api package, including the necessary configuration files, documentation, and proto definitions. The reviewer identified a version mismatch between librarian.yaml and package.json and suggested using metadata_name_override and name_pretty_override in librarian.yaml to properly handle naming conflicts with the existing bigquery library instead of manually editing the generated metadata file.

Comment thread librarian.yaml
nodejs:
default_version: v1
- name: google-cloud-bigquery-api
version: 1.0.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version specified in librarian.yaml (1.0.0) does not match the initial package version in package.json (0.1.0). Please update the version in librarian.yaml to 0.1.0 to ensure consistency across configuration files.

    version: 0.1.0

Comment thread librarian.yaml
Comment on lines +493 to +494
nodejs:
package_name: '@google-cloud/bigquery-api'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To avoid naming conflicts with the existing @google-cloud/bigquery library (which already uses the name bigquery and pretty name BigQuery), please configure metadata_name_override and name_pretty_override in librarian.yaml under the nodejs section instead of manually editing the generated .repo-metadata.json file.

    nodejs:
      package_name: '@google-cloud/bigquery-api'
      metadata_name_override: bigquery-api
      name_pretty_override: BigQuery API
References
  1. To override the metadata name and pretty name for a library to avoid naming conflicts, configure metadata_name_override and name_pretty_override in librarian.yaml instead of manually editing the generated .repo-metadata.json file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant