feat(google/bigtable/v2): onboard a new library#8857
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the new @google-cloud/bigtable-api package, onboarding both the data and admin clients for Cloud Bigtable in Node.js. The review feedback highlights several necessary corrections to the package configuration: resolving a version mismatch in librarian.yaml to align with the initial 0.1.0 version, updating the package description in package.json to accurately represent both clients, adding the missing types field in package.json for TypeScript support, and changing the release level in .repo-metadata.json to preview to match the initial pre-1.0.0 version.
| nodejs: | ||
| default_version: v1 | ||
| - name: google-cloud-bigtable-api | ||
| version: 1.0.0 |
There was a problem hiding this comment.
The library version in librarian.yaml is set to 1.0.0, which mismatches the initial version 0.1.0 defined in package.json. Please update this to 0.1.0 to maintain consistency.
version: 0.1.0| { | ||
| "name": "@google-cloud/bigtable-api", | ||
| "version": "0.1.0", | ||
| "description": "Admin client for Node.js", |
There was a problem hiding this comment.
The description of the package is currently set to "Admin client for Node.js". However, this package onboards both the data client (google/bigtable/v2) and the admin client (google/bigtable/admin/v2). To accurately reflect the package's capabilities, the description should be updated to a more general one, such as "Cloud Bigtable client for Node.js".
| "description": "Admin client for Node.js", | |
| "description": "Cloud Bigtable client for Node.js", |
| "main": "build/src/index.js", | ||
| "files": [ |
There was a problem hiding this comment.
The package is missing the "types" field in package.json. For TypeScript consumers to correctly resolve the type definitions, please specify the path to the main declaration file.
| "main": "build/src/index.js", | |
| "files": [ | |
| "main": "build/src/index.js", | |
| "types": "build/src/index.d.ts", | |
| "files": [ |
| "name": "bigtable", | ||
| "name_pretty": "Cloud Bigtable", | ||
| "product_documentation": "https://cloud.google.com/bigtable/docs", | ||
| "release_level": "stable", |
There was a problem hiding this comment.
The release level is set to "stable", but the initial version of the package in package.json is "0.1.0". New packages should start as "preview" until they are ready for general availability.
| "release_level": "stable", | |
| "release_level": "preview", |
References
- The release_level in .repo-metadata.json is determined by the package version. If the version is below 1.0.0, the release_level should be set to preview.
1 participant
No description provided.