Skip to content

feat: integrate monorepo-wide linter into CI#8833

Open
shivanee-p wants to merge 16 commits into
mainfrom
shivaneep-linter-handwritten
Open

feat: integrate monorepo-wide linter into CI#8833
shivanee-p wants to merge 16 commits into
mainfrom
shivaneep-linter-handwritten

Conversation

@shivanee-p

@shivanee-p shivanee-p commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

This pull request centralizes the ESLint and GTS checking architecture across the entire google-cloud-node monorepo. It removes redundant package-level configurations, integrates type-aware linting rules, and adds the unified linter runner (bin/linter.mjs) to the CI pipeline in a non-blocking mode to ensure a smooth transition.

  • Extended plugin:@typescript-eslint/recommended-requiring-type-checking with "project": true to catch subtle async bug patterns (e.g., floating promises, unawaited thenables).
  • Re-enabled default Google TypeScript Style (GTS) Prettier rules while preserving necessary overrides for monorepo import/promise hygiene.
  • Added a dedicated lint job to the presubmit workflow that executes npm run lint (node ./bin/linter.mjs) across PR diffs that is non-blocking for PR submission. Existing formatting or linting violations will be reported as warning badges without blocking PR merging or releasing.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@shivanee-p shivanee-p force-pushed the shivaneep-linter-handwritten branch from d4daf1a to f32b729 Compare July 8, 2026 22:51
@shivanee-p shivanee-p marked this pull request as ready for review July 8, 2026 22:51
@shivanee-p shivanee-p requested a review from a team as a code owner July 8, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant