Skip to content

chore(gaxios): replace extend dependency with native structuredClone #7951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gameroman wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −8
Open

chore(gaxios): replace extend dependency with native structuredClone #7951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions core/packages/gaxios/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
},
"repository": {
"type": "git",
"directory": "packages/gaxios",
"url": "https://github.com/googleapis/google-cloud-node-core.git"
"directory": "core/packages/gaxios",
"url": "https://github.com/googleapis/google-cloud-node.git"
},
"keywords": [
"google"
Expand All @@ -55,7 +55,6 @@
"@babel/plugin-proposal-private-methods": "^7.18.6",
"@types/cors": "^2.8.6",
"@types/express": "^5.0.0",
"@types/extend": "^3.0.1",
"@types/mocha": "^10.0.10",
"@types/multiparty": "4.2.1",
"@types/mv": "^2.1.0",
Expand Down Expand Up @@ -100,7 +99,6 @@
"webpack-cli": "^6.0.1"
},
"dependencies": {
"extend": "^3.0.2",
"https-proxy-agent": "^7.0.1",
"node-fetch": "^3.3.2"
},
Expand Down
6 changes: 2 additions & 4 deletions core/packages/gaxios/src/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
import {Agent} from 'http';
import {Readable} from 'stream';

import extend from 'extend';

import util from './util.cjs';

const pkg = util.pkg;
Expand Down Expand Up @@ -142,9 +140,9 @@ export class GaxiosError<T = ReturnType<JSON['parse']>> extends Error {

// deep-copy config as we do not want to mutate
// the existing config for future retries/use
this.config = extend(true, {}, config);
this.config = structuredClone(config);
if (this.response) {
this.response.config = extend(true, {}, this.response.config);
this.response.config = structuredClone(this.response.config);
}

if (this.response) {
Expand Down
Loading