Skip to content

fix(bigquery-jdbc): add service resource transformer for standalone IT#13893

Merged
logachev merged 1 commit into
mainfrom
kirl/standalone_test_shading
Jul 25, 2026
Merged

fix(bigquery-jdbc): add service resource transformer for standalone IT#13893
logachev merged 1 commit into
mainfrom
kirl/standalone_test_shading

Conversation

@logachev

Copy link
Copy Markdown
Contributor

Shading io.grpc without this transformer breaks some resource discovery

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the integration test POM file (java-bigquery-jdbc/pom-it.xml) to add the ServicesResourceTransformer to the maven-shade-plugin configuration. This change ensures that SPI (Service Provider Interface) files are correctly merged when creating the shaded JAR. There are no review comments, and I have no additional feedback to provide.

@logachev
logachev marked this pull request as ready for review July 24, 2026 22:05
@logachev
logachev requested review from a team as code owners July 24, 2026 22:05

@sachinpro sachinpro left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@logachev
logachev merged commit dc80fe8 into main Jul 25, 2026
204 checks passed
@logachev
logachev deleted the kirl/standalone_test_shading branch July 25, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants