chore(bigquery-jdbc): fix standalone it build#13848
Open
logachev wants to merge 5 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request parameterizes the BigQuery JDBC driver version in the integration tests (pom-it.xml and Makefile) and disables default compilation phases in pom-it.xml. The review feedback points out that if JDBC_DRIVER_VERSION is not defined in the environment, passing it directly to Maven in the Makefile will override the default version with an empty string, causing the build to fail. It suggests conditionally passing this property only when the variable is set.
logachev
enabled auto-merge (squash)
July 21, 2026 20:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
standalone-itproject (probably not a part of larger project), update makefile to pass version that will always match jdbc version.getBigQueryto be more dynamic