ci: fix unmanaged_dependency_check module install#12812
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
chingor13
force-pushed
the
fix-unmanaged-dep-check
branch
from
87f4c28 to
3c53146
Compare
meltsufin
reviewed
Apr 15, 2026
Member
meltsufin
left a comment
meltsufin
left a comment
There was a problem hiding this comment.
Don't we already have it here: .github/workflows/versions.yaml?
There should probably just be one across the entire repo.
Contributor
Author
versions.yaml check is trying to check that the release-please release PR doesn't have any -SNAPSHOT versions or if an existing release pom version already exists. The unmanaged-dependency-check is for dependencyManagement versions that should be in shared-dependencies |
blakeli0
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12704