Skip to content

ci: fix library generation presubmit#12803

Merged
chingor13 merged 6 commits intomainfrom
library-generation-tests
Apr 15, 2026
Merged

ci: fix library generation presubmit#12803
chingor13 merged 6 commits intomainfrom
library-generation-tests

Conversation

@chingor13
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 commented Apr 14, 2026

Fixes https://github.com/googleapis/google-cloud-java/pull/12801/checks?check_run_id=71341727672

failed to solve with frontend dockerfile.v0: failed to read dockerfile: error from sender: resolve : lstat .cloudbuild: no such file or directory

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Dockerfile paths in the Cloud Build configuration files to include the 'sdk-platform-java/' prefix. A review comment suggests adding the 'PROTOC_VERSION' build argument to the push-exitgate configuration to maintain consistency with the integration test environment.

@chingor13 chingor13 marked this pull request as ready for review April 14, 2026 22:00
@chingor13 chingor13 requested a review from a team as a code owner April 14, 2026 22:00
@chingor13 chingor13 changed the title build: fix library generation cloudbuild paths build: fix library generation presubmit Apr 14, 2026
@chingor13 chingor13 changed the title build: fix library generation presubmit ci: fix library generation presubmit Apr 14, 2026
@chingor13
Copy link
Copy Markdown
Contributor Author

The other sdk-platform-java GitHub action errors are pre-existing and are being fixed in other PRs (e.g. #12814)

FROM us-docker.pkg.dev/artifact-foundry-prod/docker-3p-trusted/maven@sha256:d3f04985c6a68415e36c0a6468d0f8316f27d4dbee77bc459257ba444224bd9f AS ggj-build

WORKDIR /sdk-platform-java
COPY sdk-platform-java/ .
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wouldn't the more narrow copy work here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sdk-platform-java also depends on google-auth-library which is part of the monorepo

@chingor13 chingor13 enabled auto-merge (squash) April 15, 2026 19:18
@chingor13 chingor13 requested a review from diegomarquezp April 15, 2026 19:18
@chingor13 chingor13 merged commit f62742c into main Apr 15, 2026
107 of 117 checks passed
@chingor13 chingor13 deleted the library-generation-tests branch April 15, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants