Skip to content

build: update generation config with protos from sdk-platform-java#12801

Draft
chingor13 wants to merge 6 commits intomainfrom
sdk-platform-protos
Draft

build: update generation config with protos from sdk-platform-java#12801
chingor13 wants to merge 6 commits intomainfrom
sdk-platform-protos

Conversation

@chingor13
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 commented Apr 14, 2026

Fixes #12735

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds configurations for the Showcase, Common Protos, and IAM APIs to the generation configuration. Review feedback highlights an inconsistency in the IAM distribution name, which suggests only version 1 is included despite the presence of versions 2 and 3. Additionally, a placeholder URL in the Showcase product documentation needs to be replaced with a valid link.

Comment thread generation_config.yaml
Comment thread generation_config.yaml Outdated
@chingor13 chingor13 force-pushed the sdk-platform-protos branch from 43a8bfe to 5b582e1 Compare April 15, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sdk-platform-java] generated modules are not in monorepo config after merge

2 participants