Skip to content

fix(o11y): composite tracer to process url changes #12754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blakeli0 merged 2 commits into from
Apr 10, 2026
Merged

fix(o11y): composite tracer to process url changes #12754

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e188fc
fix(o11y): composite tracer to process url changes
diegomarquezp Apr 10, 2026
c1a29ba
test: verify in order
diegomarquezp Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/CompositeTracer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,4 +220,11 @@ public void injectTraceContext(java.util.Map<String, String> carrier) {
child.injectTraceContext(carrier);
}
}

@Override
public void requestUrlResolved(String requestUrl) {
for (ApiTracer child : children) {
child.requestUrlResolved(requestUrl);
}
}
}
7 changes: 7 additions & 0 deletions ...tform-java/gax-java/gax/src/test/java/com/google/api/gax/tracing/CompositeTracerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,4 +279,11 @@ void testInjectTraceContext() {
inOrder.verify(child1).injectTraceContext(carrier);
inOrder.verify(child2).injectTraceContext(carrier);
}

@Test
void testRequestUrlResolved() {
compositeTracer.requestUrlResolved("the-url");
verify(child1).requestUrlResolved("the-url");
verify(child2).requestUrlResolved("the-url");
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other tests in this class (such as testInjectTraceContext), it is recommended to use inOrder.verify() to ensure that the composite tracer delegates to its children in the expected order.

Suggested change
verify(child1).requestUrlResolved("the-url");
verify(child2).requestUrlResolved("the-url");
inOrder.verify(child1).requestUrlResolved("the-url");
inOrder.verify(child2).requestUrlResolved("the-url");

}
}
Loading