feat(docs): add devsite-help and snippets for Retries, Update Masks, and OCC by bshaffer · Pull Request #15308 · googleapis/google-cloud-dotnet

bshaffer · 2025-12-08T21:41:15Z

I followed the examples of other pages in docs/devsite-help, but it's quite possible I'm missing a critical aspect. I also am not sure how these will be tested.

I ran all samples locally to verify they worked but please take a look and review

Docs content
Sample code
How I've connected things up

gemini-code-assist · 2025-12-08T21:41:33Z

Summary of Changes

Hello @bshaffer, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the documentation for Google Cloud .NET client libraries by introducing three new guides focused on advanced usage patterns. These guides cover Optimistic Concurrency Control for IAM policies, flexible retry and timeout configurations, and efficient partial resource updates using update masks. Each guide is complemented by practical C# code snippets, providing developers with clear instructions and examples to implement these critical features effectively.

Highlights

New Documentation Pages: Added comprehensive guides for Optimistic Concurrency Control (OCC) for IAM, configuring Retries and Timeouts, and utilizing Update Masks.
C# Code Snippets: Introduced corresponding C# code examples to illustrate the practical application of OCC, retry mechanisms, and update masks within Google Cloud .NET client libraries.
Table of Contents Integration: Updated the docs/devsite-help/toc.yml file to ensure the new documentation pages are discoverable and properly linked within the documentation structure.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions · 2025-12-08T21:42:32Z

Pull request diff results
No APIs have changed in this PR. Exiting diff.

gemini-code-assist

Code Review

This pull request adds valuable documentation and examples for Retries, Update Masks, and Optimistic Concurrency Control for IAM. The documentation content is clear and well-structured. However, all the new C# code snippets contain several compilation errors that need to be addressed. These include incorrect async method signatures, use of an undefined _fixture variable, a missing semicolon, and unused using directives. I've left specific comments with suggestions to fix these issues. Once these are resolved, the snippets will be great examples for users.

… OCC for IAM

github-actions · 2025-12-10T22:14:53Z

Pull request diff results
No APIs have changed in this PR. Exiting diff.

amanda-tarafa

Let me know how I can help.

amanda-tarafa · 2025-12-15T23:28:39Z

+            string projectId = "your-project-id";
+            string secretId = "test-secret";


So that this is run, these need to come from the fixture.

There is no secret in the fixture, should I add a _fixture.CreateSecret()?

amanda-tarafa

Let me know if you prefer I do the finishing touches.

amanda-tarafa · 2026-01-26T22:48:10Z

@@ -0,0 +1,22 @@
+# Optimistic Concurrency Control (OCC) for IAM


Can't find the other comment but yes, I think it'd be best to refer to IAM as an example only and remove it from anywhere that's general (the titles and file names etc.) and could imply that OCC only applies to IAM resources.

amanda-tarafa · 2026-01-27T00:02:24Z

+        string role = "roles/cloudkms.cryptoKeyEncrypterDecrypter";
+        string member = "user:betterbrent@google.com";


Thinking about this more, there are a couple of things that might be a problem here:

We are changing permissions on the project that we run tests in, and we have automation for maintaining permissions on it, that will complain about these changes.

It's OK to harcode these values, but we should use more inocuos roles and less specific members.

Because we can already create/destroy topics on the fixture, what about if we use the Pub/Sub Publisher client instead to update the IAM policy on the topic, and we can set the viewer role on the topic for "domain:google.com"?

Let me know if you'd prefer me to work on that one.

Without knowing more about the way these tests are set up, I can't say I follow what the issue is we're trying to solve or how to solve it. If these are changes you feel like you could do easily instead, please do so!

amanda-tarafa · 2026-01-27T00:08:15Z

+    public void UpdateMasks()
+    {
+        string projectId = _fixture.ProjectId;;
+        string secretId = "test-secret";


We don't have a test-secret so this will fail. Either we create and destroy a secret on the fixture, or we change this example to use a Pub/Sub topic and use the utilities that we already have on the fixture.

Either way works for me, just let me know which you prefer (and maybe some guidance for how to set it up)

amanda-tarafa

I'll take it from here for the changes in the tests. Thanks!!!

And I'll send it for you to review once I've done that.

amanda-tarafa · 2026-01-30T22:54:50Z

Closing in favour of #15423 which just tweks the sample code. Thanks @bshaffer !

bshaffer requested a review from a team December 8, 2025 21:41

gemini-code-assist Bot reviewed Dec 8, 2025

View reviewed changes

feat(docs): add devsite-help and tests for Retries, Update Masks, and…

cd55d59

… OCC for IAM

bshaffer force-pushed the add-client-help-docs branch from ad64163 to cd55d59 Compare December 10, 2025 22:13

googleapis deleted a comment from github-actions Bot Dec 10, 2025

update copyright

8621a55

amanda-tarafa requested changes Dec 16, 2025

View reviewed changes

googleapis deleted a comment from github-actions Bot Dec 16, 2025

addressing many review comments

cfcd79c

googleapis deleted a comment from github-actions Bot Jan 9, 2026

remove retries from toc

6e594a6

googleapis deleted a comment from github-actions Bot Jan 10, 2026

bshaffer requested a review from amanda-tarafa January 13, 2026 18:36

amanda-tarafa requested changes Jan 27, 2026

View reviewed changes

address review comments

4b30c4c

bshaffer requested a review from amanda-tarafa January 29, 2026 21:36

bshaffer changed the title ~~feat(docs): add devsite-help and snippets for Retries, Update Masks, and OCC for IAM~~ feat(docs): add devsite-help and snippets for Retries, Update Masks, and OCC Jan 29, 2026

amanda-tarafa reviewed Jan 30, 2026

View reviewed changes

amanda-tarafa closed this Jan 30, 2026

		string projectId = "your-project-id";
		string secretId = "test-secret";

		@@ -0,0 +1,22 @@
		# Optimistic Concurrency Control (OCC) for IAM

		string role = "roles/cloudkms.cryptoKeyEncrypterDecrypter";
		string member = "user:betterbrent@google.com";

Conversation

bshaffer commented Dec 8, 2025

Uh oh!

gemini-code-assist Bot commented Dec 8, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

github-actions Bot commented Dec 8, 2025

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Dec 10, 2025

Uh oh!

amanda-tarafa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

amanda-tarafa Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

bshaffer Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amanda-tarafa left a comment

Choose a reason for hiding this comment

Uh oh!

amanda-tarafa Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amanda-tarafa Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

bshaffer Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

amanda-tarafa Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

bshaffer Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

amanda-tarafa left a comment

Choose a reason for hiding this comment

Uh oh!

amanda-tarafa commented Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

bshaffer Jan 9, 2026 •

edited

Loading