feat: Spanner.V1 BatchWrite#15122
Closed
robertvoinescu-work wants to merge 1 commit intogoogleapis:mainfrom
Closed
feat: Spanner.V1 BatchWrite#15122robertvoinescu-work wants to merge 1 commit intogoogleapis:mainfrom
robertvoinescu-work wants to merge 1 commit intogoogleapis:mainfrom
Conversation
4c23ade to
f2c5f92
Compare
606bdfd to
d803b83
Compare
purva9413
reviewed
Oct 2, 2025
d803b83 to
a91b1b4
Compare
89082c8 to
0ccf88d
Compare
0ccf88d to
39f2ccc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User need access to the
BatchWriteAPI through the Spanner SDK. This is important becauseBatchWriteallows users to submit a set of bulk mutations in batch for efficient processing. To address this, We introduce aBatchWriteAsyncmethod inPooledSessionexposing the API in Spanner.V1.Details
BatchWriteAsyncmethod avoids transaction management.SpannerClient.BatchWrite,AsyncStream<>, is a sealed class (i.e. cannot be mocked) with no public constructor (i.e. cannot be explicitly created in our tests). We could introduce wrappers to allow for mocking, but that adds a lot of abstraction layers I'm not sure we want.Non Goals