feat(storage): migrate sync client to unified checksum options#16264
feat(storage): migrate sync client to unified checksum options#16264v-pratap wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces UploadChecksumValidationOption and DownloadChecksumValidationOption using a new ChecksumAlgorithm enum to replace several deprecated checksum options and classes. It updates internal hash functions, validators, and tests to support these new options. The review feedback highlights that using the deprecated types in hash_function.cc, hash_validator.cc, and object_requests.cc will trigger -Wdeprecated-declarations compiler warnings, suggesting the inclusion of deprecation warning disable headers. Additionally, the reviewer recommends refactoring duplicated fallback logic for resolving checksum settings into a shared helper function to align with the repository style guide.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16264 +/- ##
==========================================
- Coverage 92.27% 92.27% -0.01%
==========================================
Files 2218 2219 +1
Lines 206654 206686 +32
==========================================
+ Hits 190699 190720 +21
- Misses 15955 15966 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
d2b9add to
68aaf3e
Compare
eae7fbf to
59e1bf1
Compare
115a30d to
163523d
Compare
163523d to
530f38b
Compare
Migrates the Sync client to use the newly introduced unified checksum options. Also includes the necessary fallback logic to support users who are still using the deprecated options.
Note: This PR is stacked on top of #16261 and includes its commits. It should be merged after #16261.